Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a different separator for sed 's' command #13

Open
wants to merge 1 commit into
base: halium-9.0
Choose a base branch
from
Open

Use a different separator for sed 's' command #13

wants to merge 1 commit into from

Commits on Feb 24, 2024

  1. Use a different separator for sed 's' command 

    The sed expression that is used to set specific config values doesn't work while trying to set the following config: 
CONFIG_ANDROID_BINDER_DEVICES="binder,hwbinder,vndbinder,anbox-binder,anbox-hwbinder,anbox-vndbinder"
Instead, it throws the following error:
sed: -e expression Halium#1, char 80: unknown option to `s'

This is because the argument separator (comma) also appears in the expression argument itself. That causes sed to interpret the 'h' in 'binder,hwbinder' as an option to the 's' command.

This change makes semicolon (;) the separator instead of comma (,) to avoid the issue. If a new config value with a semicolon in it is ever added to the list in $CONFIGS_EQ, this will have to be changed.
    @GlowingScrewdriver
    GlowingScrewdriver authored Feb 24, 2024
    Configuration menu
    Copy the full SHA
    6dfcf73 View commit details
    Browse the repository at this point in the history