gnutls: build Guile bindings

[aconchillo]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

This takes a different approach than #59481 by simply building Guile bindings by default when installing gnutls. However, that means that guile is now required.

❯ brew audit --strict gnutls
gnutls:
  * Formula gnutls contains deprecated SPDX licenses: ["LGPL-2.1"].

[gromgit]

LGPL-2.1 is indeed a deprecated license ID, and it's not how GnuTLS is licensed anyway. Based on https://gitlab.com/gnutls/gnutls/-/blob/master/LICENSE, the correct stanza is more like:

license ["LGPL-2.1-or-later", "GPL-3.0-only"]

[gromgit]

Sorry, that license syntax was for dual-licensing, which doesn't apply here. Use the following instead:

# license "LGPL-2.1-or-later AND GPL-3.0-only" - review syntax after resolving https://github.com/Homebrew/brew/pull/8260
license "GPL-3.0-only"

[aconchillo]

Thanks @gromgit. I will update once Homebrew/brew#8260 is resolved.

I will also close #59481 in favor of this one since there's no way we can fix the dynamic library issue.

[aconchillo]

For now updated it to use license "LGPL-2.1-or-later".

[gromgit]

Please use the exact license stanza that I mentioned. Because different parts of GnuTLS are licensed differently, Homebrew currently requires the most restrictive license be listed.

[aconchillo]

@gromgit done! apologies, i misunderstood your previous message.

[aconchillo]

hi @gromgit. is there any way for me to remove the deprecated license label and re-run the checks. I believe they failed for some non-gnutls related issues.

[SMillerDev]

You can rebase and push

[aconchillo]

duh... true. 🤦‍♂️

[aconchillo]

Any idea what's going on with this

Compiling Agda.Primitive in /usr/local/Cellar/agda/2.6.1/share/x86_64-osx-ghc-8.10.1/Agda-2.6.1/lib/prim/Agda/Primitive.agdai to /private/tmp/agda-test-20200814-1559-dm8svm/./jAgda.Agda.Primitive.js
Compiling SimpleTest in /private/tmp/agda-test-20200814-1559-dm8svm/SimpleTest.agdai to /private/tmp/agda-test-20200814-1559-dm8svm/./jAgda.SimpleTest.js
Error: agda: failed
An exception occurred within a child process:
  MethodDeprecatedError: Calling Language::Haskell::Cabal.cabal_sandbox is deprecated! There is no replacement.
Please report this issue to the homebrew/core tap (not Homebrew/brew or Homebrew/core):
  /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/agda.rb:150

[aconchillo]

Seems related to this issue #58984

[aconchillo]

This PR #59709 will fix the issue once merged.

[aconchillo]

Rebased now that #59709 is merged and added a caveat I found was necessary to use the bindings properly.

[SMillerDev]

Thanks @aconchillo ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

[BrewTestBot]

🤖 A scheduled task has triggered a merge.