Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

agda: fix test by migrating to Cabal v2 commands #59709

Closed
wants to merge 1 commit into from

Conversation

Josh-Tilles
Copy link
Contributor

Fixes #58984

Relates to #55253

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@Rylan12 Rylan12 added the cabal v1 deprecation Deprecate cabal sandbox label Aug 15, 2020
@BrewTestBot BrewTestBot added the haskell Haskell use is a significant feature of the PR or issue label Aug 15, 2020
@chenrui333
Copy link
Member

@MerelyAPseudonym thanks for the PR, do you think you can take on the cabal_v1 deprecation on L43-L55? Thanks!

@Josh-Tilles
Copy link
Contributor Author

@chenrui333 you're welcome! And I'm happy to try updating the rest of the formula as well.

@chenrui333
Copy link
Member

Sounds good, I will keep this a little bit longer than, thanks for the work!

This was referenced Aug 17, 2020
@fishtreesugar fishtreesugar mentioned this pull request Aug 18, 2020
@chenrui333 chenrui333 mentioned this pull request Aug 23, 2020
@chenrui333
Copy link
Member

let's take iterative approach on this as there are so many dependencies waiting for this fix.

@chenrui333
Copy link
Member

Thanks @MerelyAPseudonym !!

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cabal v1 deprecation Deprecate cabal sandbox haskell Haskell use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agda test fails
4 participants