Fix peerdependencies versions #1430
Conversation
🦋 Changeset detectedLatest commit: 1dce74c The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for houdinigraphql canceled.
|
✅ Deploy Preview for houdini-docs-next canceled.
|
packages/houdini/package.json
Outdated
| @@ -61,7 +60,7 @@ | |||
| "vite-plugin-watch-and-run": "^1.7.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "vite": "^5.3.3" | |||
| "vite": "^6.0.3" | |||
There was a problem hiding this comment.
i think this would be a breaking change. if you want to add vite6, that can be done in a minor, but removing vite5 would be breaking. (a user stuck on vite5 cannot update houdini anymore)
There was a problem hiding this comment.
Hmm that's fair. So something like this would be a better solution then?
| "vite": "^6.0.3" | |
| "vite": "^5.3.3 || ^6.0.3" |
(given that we test that it also still works with vite 5)
There was a problem hiding this comment.
yes, that can be done in a minor (adding support for vite6 is a feature rather than a patch)
syntax looks fine.
|
Alright everything should be good now. |
This PR bumps the peerdependency versions of vite and sveltekit, as we apparently seem to have missed these between the peerdependencies and vite 6 PRs.
To help everyone out, please make sure your PR does the following:
pnpm run testsandcd integration && pnpm run testspnpm changeset