Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peerdependencies versions #1430

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Fix peerdependencies versions #1430

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ff1888
Fix peerdependencies after vite 6 merge
SeppahBaws Jan 27, 2025
621f6c0
Add changeset
SeppahBaws Jan 27, 2025
1dce74c
Fix backcompat with vite 5
SeppahBaws Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/new-planets-sing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'houdini-plugin-svelte-global-stores': patch
'houdini-adapter-static': patch
'houdini': patch
---

Fix vite peerdependency versions
2 changes: 1 addition & 1 deletion packages/adapter-static/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"react-dom": "^19.0.0"
},
"peerDependencies": {
"vite": "^5.3.3"
"vite": "^6.0.3"
},
"files": [
"build"
Expand Down
3 changes: 1 addition & 2 deletions packages/houdini/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"prettier": "^2.8.3",
"rollup": "^4.28.1",
"scripts": "workspace:^",
"vite": "^6.0.3",
"vitest": "^1.6.0"
},
"dependencies": {
Expand Down Expand Up @@ -61,7 +60,7 @@
"vite-plugin-watch-and-run": "^1.7.0"
},
"peerDependencies": {
"vite": "^5.3.3"
"vite": "^6.0.3"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this would be a breaking change. if you want to add vite6, that can be done in a minor, but removing vite5 would be breaking. (a user stuck on vite5 cannot update houdini anymore)

Copy link
Collaborator Author

@SeppahBaws SeppahBaws Jan 27, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm that's fair. So something like this would be a better solution then?

Suggested change
"vite": "^6.0.3"
"vite": "^5.3.3 || ^6.0.3"

(given that we test that it also still works with vite 5)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that can be done in a minor (adding support for vite6 is a feature rather than a patch)

syntax looks fine.

},
"files": [
"build"
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-svelte-global-stores/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"recast": "^0.23.1"
},
"peerDependencies": {
"@sveltejs/kit": "^2.5.3",
"@sveltejs/kit": "^2.9.0",
"svelte": "^5.0.0"
},
"files": [
Expand Down
50 changes: 9 additions & 41 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading