Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Feature merge results #187

Draft
wants to merge 27 commits into
base: develop
Choose a base branch
from
Draft

[WIP] Feature merge results #187

wants to merge 27 commits into from

Conversation

LeonardSchmiester
Copy link
Member

No description provided.

dweindl
dweindl approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@dweindl dweindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great if you could add typehints, and add an Arguments section to the docstrings

misc/mergeResultFiles.py Outdated Show resolved Hide resolved
@LeonardSchmiester @dweindl
Update misc/mergeResultFiles.py
07c3a04 
fixed typo

Co-Authored-By: Daniel Weindl <[email protected]>
@dweindl
Copy link
Member

dweindl commented Sep 7, 2019

ping

@dweindl
Copy link
Member

dweindl commented Oct 4, 2019

@LeonardSchmiester : ping

@dweindl dweindl changed the title Feature merge results [WIP] Feature merge results Dec 12, 2019
@dweindl
Copy link
Member

dweindl commented Mar 13, 2020

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- misc/mergeResultFiles.py  5

See the complete overview on Codacy

@sonarcloud
Copy link

sonarcloud bot commented Apr 21, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 1 Security Hotspot to review)
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl
Copy link
Member

dweindl commented Jun 16, 2020

@LeonardSchmiester : ping

@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl self-requested a review March 13, 2021 10:38
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl removed their request for review March 25, 2021 09:04
dweindl and others added 7 commits June 28, 2021 09:20
@dweindl
SuperMUC build script: skip boost
7f569a9
@dweindl
Fix race condition with parallel HDF5 calls (#345)
eb33a10 
* Fix race condition with parallel HDF5 calls

Add some locks, in particular for H5Location::nameExists.
Also remove some unnecessary H5File::getId calls.

* Safely close HDF5 files

* Check pthread_create retval

* cleanup
@dweindl
Fix HDF5 generation for state reinitialization with estimated initial…
72f29d9 
… conditions (#344)
@dweindl
Cleanup PEtab import (#346)
46589e5
@dweindl
Update AMICI to develop@8ef53c88 (#347)
e5e4fb3 
git subrepo clone --branch=develop --force [email protected]:AMICI-dev/AMICI.git deps/AMICI 

subrepo:
  subdir:   "deps/AMICI"
  merged:   "8ef53c88"
upstream:
  origin:   "[email protected]:AMICI-dev/AMICI.git"
  branch:   "develop"
  commit:   "8ef53c88"
git-subrepo:
  version:  "0.4.1"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "a04d8c2"
@dweindl
Fixup AMICI
98a0746 
AMICI-dev/AMICI#1522
@dweindl
Merge branch 'develop' into feature_mergeResults
aa9db59
@sonarcloud
Copy link

sonarcloud bot commented Jul 12, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl force-pushed the develop branch 2 times, most recently from c25dd97 to 3b13b04 Compare July 13, 2021 14:22
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dweindl dweindl marked this pull request as draft May 6, 2022 11:52
@dweindl dweindl self-requested a review May 6, 2022 11:52
@dweindl dweindl removed their request for review May 20, 2022 15:50
@dweindl dweindl force-pushed the develop branch 2 times, most recently from bbf24f8 to e4fb08a Compare March 28, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dweindl dweindl dweindl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeonardSchmiester @dweindl @paulstapor