Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AMICI to v0.20.0 #378

Merged
merged 25 commits into from
Dec 11, 2023
Merged

Update AMICI to v0.20.0 #378

merged 25 commits into from
Dec 11, 2023

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Dec 5, 2023

Changes

  • Update AMICI to v0.20.0

    • Fixes some amici setuptools incompatibility
    • Adapt to changes in logging
  • Handle git permission issues

  • Fix RTD issues

Requires:

  • CMake >= 3.22

git subrepo clone (merge) --branch=v0.20.0 --force [email protected]:AMICI-dev/AMICI.git deps/AMICI

subrepo:
  subdir:   "deps/AMICI"
  merged:   "ffcbf665"
upstream:
  origin:   "[email protected]:AMICI-dev/AMICI.git"
  branch:   "v0.20.0"
  commit:   "ffcbf665"
git-subrepo:
  version:  "0.4.6"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "110b9eb"
@dweindl dweindl self-assigned this Dec 5, 2023
Copy link

sonarcloud bot commented Dec 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

24.0% 24.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@dweindl dweindl marked this pull request as ready for review December 11, 2023 12:18
@dweindl dweindl merged commit 2803ff3 into develop Dec 11, 2023
8 of 9 checks passed
@dweindl dweindl deleted the update_amici branch December 11, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant