-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Res r3 model issue #318 #338
Conversation
Signed-off-by: Dietmar Warning <[email protected]>
because of additional Verilog-A model reorganization of directory structure and install process was introduced Signed-off-by: Dietmar Warning <[email protected]>
Signed-off-by: Dietmar Warning <[email protected]>
Signed-off-by: Dietmar Warning <[email protected]>
The rshspec parameter for rppd is not explicitly defined in the resistors_mod.lib and resistors_mod_mismatch.lib files under the rppd subcircuit model, similar to rsil and rhigh. |
It is not wrong because the rsh_rppd (and the others) are use and defined in cornerRES.lib. |
Looking at the sheer number of changed files (incl. a change of the folder structure) this PR is hefty, but switching to the R3-CMC model is excellent to have. I think we should also merge soon, before this triggers even more complications later. @sergeiandreyev @KrzysztofHerman What do you think? @dwarning Do you think we are ready to merge? |
Hi @hpretl, this PR went through internal IHP review and as I understand it is ready for merge, I'll double check tomorrow |
This PR fixes #318 and by using the r3_cmc Verilog-A model is now compatible with the model used in the commercial pdk.
Attached document show very few simulation examples also for noise simulation amongst others:
sg13_res_r3_model.pdf
Because of using a Verilog-A model reorganization of directory structure was needed and adms or openvaf is needed respectively used simulator.