Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow guild quests to be dispensed by player level as well as rank #2688

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ajrb
Copy link
Collaborator

@ajrb ajrb commented Aug 16, 2024

Guild quests can be dispensed by player level as well as rank if minReq is <10 depending on the guild implementation. Proposed alternative to #2678 .

Enabled for Mages Guild and Knightly Orders.

Will add for Witch Coverns if evidence from classic Daggerfall is provided that contradicts https://en.uesp.net/wiki/Daggerfall:Witch_Covens

Only other thought is whether this change should have a way to disable this for players who prefer how DFU 1.0 currently works. Happy to add a setting or ini file property if you think worthwhile, @KABoissonneault & @petchema ?

Guild quests can be dispensed by player level as well as rank if minReq is <10 depending on the guild implementation.

Enabled for Mages Guild and Knightly Orders.
@ajrb ajrb added the classic variance Fixes a bug or behaviour from classic. Or could be result of lacking classic info. label Aug 16, 2024
@petchema
Copy link
Collaborator

petchema commented Aug 16, 2024

That's not so simple to check if witches coven consider rank or level, given that all their quests are reputation-gated (when there's any precondition).
Unless you were thinking about adding a rank-gated witches quest to classic Daggerfall to check how it'd behave? That's a bit out of my league.
If that helps, a save near the Tamarilyn Witches:
SAVE5 - Looking for witches.zip
Character never had previous contact with them, so I assume reputation is about neutral.

petchema
petchema previously approved these changes Aug 16, 2024
Copy link
Collaborator

@petchema petchema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to work as advertised, with or without player quest selection.
No remarks about code either

UESP rep based proven wrong by testing classic
@ajrb
Copy link
Collaborator Author

ajrb commented Aug 18, 2024

Switched witches quest dispensing to player level as proven in classic with that save.

It's possible that reputation also enables offers as UESP states, but I'm not implementing that unless it's actually proven to be the case by someone who cares enough to test it. It would require having a witch covern rep at > 10x player level and asking for quests. I think this is unlikely to happen in game but could be tried in classic by finding a covern, doing 3 covern quests successfully without reaching level 2, then getting offered one of the last 3 quests from https://en.uesp.net/wiki/Daggerfall:Witch_Covens.

If someone does show this is how classic works, then I'll implement a special case for witches coverns which was the only faction quests that remained based on reputation since they were all changed back in December 2018 when it was shown that UESP was wrong (at that time) and all switched to rank/level based dispensing. Otherwise I consider it needless complexity based on an unreliable source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classic variance Fixes a bug or behaviour from classic. Or could be result of lacking classic info.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants