-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce handshake command + tighter ping UI #468
Conversation
cd1ba2f
to
a732c02
Compare
import qualified Prettyprinter as PP | ||
|
||
data HandShakeCmd = HandShakeCmd | ||
{ endPoint :: !Ping.EndPoint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't be a separate command. It should live under the ping command as something like handshake-only
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've settled for cardano-cli ping --handshake-only
here on Slack.
a732c02
to
742e599
Compare
Will likely be superseded by #524 in the end |
This PR is stale because it has been open 45 days with no activity. |
Changelog
Context
cardano-cli ping --unixsock
not sending pings #49How to trust this PR
cardano-cli handshake
, witness it workscardano-cli ping -u SOCKET
, witness it doesn't exist anymore.Checklist