ping --handshake-only

[felix-lipski]

Changelog

- description: |
    unixsoc depend on handshake-only
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

issue
previous PR

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[felix-lipski]

This incorrectly omits all the other options in this case.
This is because visibility in optparse-appicative can only be Internal, Hidden or Visible.
There is no fourth visibility to hide an option in the full description and show it in the brief description.
So we either omit these options in the brief description here, or they will be doubled in the full description.

[smelc]

Hum I see, there is no good solution in the current state.

@Jimbo4350> would be it acceptable to instead:

1. Keep only one parser (e.g. pPing) and
2. Indicate in -u/--unixsock that this option requires --handshake-only
3. Perform the check that if -u is specified, then so is --handhshake-only, when the command starts to run? (as opposed to doing the check in the parser)

[carbolymer]

Formatting is off. Can you run this through stylish?
https://github.com/input-output-hk/cardano-node-wiki/wiki/Style-guide#code-linting-and-formatting-tools

[github-actions]

This PR is stale because it has been open 45 days with no activity.

[smelc]

Since this is not a priority, I'm letting the stale bot do its thing. This PR (and the previous one) will still be there if we want to revisit.

[github-actions]

This PR is stale because it has been open 45 days with no activity.

[github-actions]

This issue was closed because it has been stalled for 60 days with no activity.