Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esmf, fms, g2, g2tmpl and mapl versions #1256

Merged
merged 6 commits into from
Aug 21, 2024

Conversation

RatkoVasic-NOAA
Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA commented Aug 20, 2024

Summary

Update default versions of esmf, fms, g2, g2tmpl and mapl packages.

Testing

Tested previously with UFS-WM

Applications affected

UFS WM

Systems affected

All

Dependencies

Issue(s) addressed

Resolves #1255
Resolves #1106

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@climbfuji
Copy link
Collaborator

We will need updates of esmf versions in a few other templates (skylab-dev, unified-dev, ...). I can push to your branch if you want. Are you sure you want [email protected] and not the lates 2024.02? Doesn't seem to make sense to me to go with an older version.

@climbfuji
Copy link
Collaborator

we need to pull in Matt's mapl update PR from spack develop

@RatkoVasic-NOAA
Copy link
Collaborator Author

RatkoVasic-NOAA commented Aug 20, 2024

We will need updates of esmf versions in a few other templates (skylab-dev, unified-dev, ...). I can push to your branch if you want. Are you sure you want [email protected] and not the lates 2024.02? Doesn't seem to make sense to me to go with an older version.

I think skylab-dev and unified-dev have already correct versions.
As for fms, I was asked to test 2024.01 and that one passed WM tests. Not sure why they didn't ask for newer version.

@climbfuji
Copy link
Collaborator

I think we should use the latest available fms for spack-stack-1.8.0

@RatkoVasic-NOAA
Copy link
Collaborator Author

I think we should use the latest available fms for spack-stack-1.8.0

I can do that, but we have to update spack as well, current one have latest [email protected]
in var/spack/repos/builtin/packages/fms/package.py

@climbfuji
Copy link
Collaborator

Let me take care of the spack updates (fms, mapl) - will be ready in 30mins or so

…, configs/containers/specs/jedi-ci.yaml, configs/templates/ufs-weather-model-static/spack.yaml
@climbfuji
Copy link
Collaborator

@RatkoVasic-NOAA I took the liberty to push to your branch. This PR now depends on JCSDA/spack#466

@RatkoVasic-NOAA
Copy link
Collaborator Author

I saw that, thanks.

@climbfuji
Copy link
Collaborator

I'll push the spack submodule ptr update and .gitmodules reversal after the current CI tests finished (last one is ubuntu gnu, currently doing mapl - close to finish).

@climbfuji climbfuji self-requested a review August 20, 2024 21:32
@climbfuji climbfuji requested a review from eap August 20, 2024 22:12
@climbfuji
Copy link
Collaborator

@eap added you as reviewer FYI (several updates I am making to the jedi-ci specs)

@climbfuji climbfuji merged commit 6008ff7 into JCSDA:develop Aug 21, 2024
8 checks passed
DavidHuber-NOAA added a commit to DavidHuber-NOAA/spack-stack that referenced this pull request Aug 21, 2024
* jcsda/develop:
  Update esmf, fms, g2, g2tmpl and mapl versions (JCSDA#1256)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2 participants