Update fms and mapl from spack-develop ([email protected], [email protected]) #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bug fix for mapl: configure mvapich2 * Update var/spack/repos/builtin/packages/mapl/package.py --------- Co-authored-by: Matt Thompson <[email protected]>
climbfuji
requested review from
mathomp4,
RatkoVasic-NOAA and
AlexanderRichert-NOAA
4 tasks
mathomp4
approved these changes
Aug 20, 2024
|
@RatkoVasic-NOAA The CI builds in JCSDA/spack-stack#1256 are looking good. I think this PR can be approved and merged. If we really run into problems testing the ufs with the spack-stack-1.8.0 release candidate next week, we can always roll back (in the spack-stack configs) to 2024.01. |
RatkoVasic-NOAA
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls in changes (cherry-picked commits) for [email protected], [email protected], [email protected], and a bug fix for using mvapich2 with mapl.
Upstream spack PRs:
For testing, see JCSDA/spack-stack#1256