-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ListComboBox #627
Open
hamen
wants to merge
90
commits into
main
Choose a base branch
from
im-222-listcombobox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add ListComboBox #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamen
force-pushed
the
im-222-listcombobox
branch
from
October 14, 2024 09:35
1463fb5
to
826ad6a
Compare
This was
linked to
issues
Oct 14, 2024
When testing, I found these issues:
This is just a quick smoke test. I will not review this PR until these are fixed, as it's bound to introduce more changes (and hopefully not more bugs) |
This was referenced Oct 15, 2024
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
This reverts commit f336503.
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
Signed-off-by: Ivan Morgillo <[email protected]>
They changed the config and didn't implement a migration of the old config to the new config 🤦
Stuff is still broken, maybe more than before :P
Signed-off-by: Ivan Morgillo <[email protected]>
hamen
force-pushed
the
im-222-listcombobox
branch
from
October 16, 2024 14:04
2327a72
to
3cef1d5
Compare
Signed-off-by: Ivan Morgillo <[email protected]>
* rename a bunch of lambdas to make the linter happy Signed-off-by: Ivan Morgillo <[email protected]> * Fix #632 Signed-off-by: Ivan Morgillo <[email protected]> * stitch broken tests Signed-off-by: Ivan Morgillo <[email protected]> * update API files Signed-off-by: Ivan Morgillo <[email protected]> * stitch IDE sample Signed-off-by: Ivan Morgillo <[email protected]> * make the formatter happy * renamed a bunch of lambdas and shushed the linter Signed-off-by: Ivan Morgillo <[email protected]> * format EditableComboBox * improve test for disabled ComboBox Signed-off-by: Ivan Morgillo <[email protected]> --------- Signed-off-by: Ivan Morgillo <[email protected]> Co-authored-by: morgillo <[email protected]>
* remove rounded corner from IntUiBridge SimpleListItemMetrics Signed-off-by: Ivan Morgillo <[email protected]> * make the formatter happy --------- Signed-off-by: Ivan Morgillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR contains new components that are meant to replace the
Dropdown
composable.ListComboBox
This is the simplest way to create an editable dropdown menu that shows a list and allows adding a value that is not present in the list. The API is very minimal to keep things "nice and easy":
ComboBox
This is one of the building blocks and represents the editable version of the dropdown component, containing the empty popup and the editable text field.
NotEditableComboBox
This is one of the building blocks and represents the editable version of the dropdown component, containing the empty popup and the text label.
SimpleListItem
This is a pre-made composable that can help to create a list
ComboBox
without stressing over the styling.PopupContainer
This is the empty popup used by the
ComboBox
that can be filled with custom composables.