Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ListComboBox #627

Open
wants to merge 90 commits into
base: main
Choose a base branch
from
Open

Add ListComboBox #627

wants to merge 90 commits into from

Commits on Oct 16, 2024

  1. integrate ComboBox in Standalone

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8caf3ac View commit details
    Browse the repository at this point in the history
  2. add ComboBoxes to SwingComparisonTabPanel

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0fa2a82 View commit details
    Browse the repository at this point in the history
  3. fix text color in ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a664dda View commit details
    Browse the repository at this point in the history
  4. add a bit of space below combobox in IDE example

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a562564 View commit details
    Browse the repository at this point in the history
  5. tune ComboBox popup padding

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d568e73 View commit details
    Browse the repository at this point in the history
  6. fix ComboBox field background color

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    dc501e6 View commit details
    Browse the repository at this point in the history
  7. extract textStyle in ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b8d9f68 View commit details
    Browse the repository at this point in the history
  8. update API files

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bfe2503 View commit details
    Browse the repository at this point in the history
  9. make the formatter happy

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e85a693 View commit details
    Browse the repository at this point in the history
  10. fix ComboBox border

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f1e0986 View commit details
    Browse the repository at this point in the history
  11. tune ComboBox focus

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6b6f888 View commit details
    Browse the repository at this point in the history
  12. Revert "tune ComboBox focus"

    This reverts commit f336503.
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e76f339 View commit details
    Browse the repository at this point in the history
  13. iterate on focus

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    77dd458 View commit details
    Browse the repository at this point in the history
  14. reformat

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b73b9f6 View commit details
    Browse the repository at this point in the history
  15. remove cursorBrush style

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    62d67fa View commit details
    Browse the repository at this point in the history
  16. add isEditable flag to ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9e165e3 View commit details
    Browse the repository at this point in the history
  17. make the formatter happy

    morgillo authored and hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    436e639 View commit details
    Browse the repository at this point in the history
  18. tune ComboBox menu horizontal padding

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f3ccca4 View commit details
    Browse the repository at this point in the history
  19. remove offset from Standalone style

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f86f3e7 View commit details
    Browse the repository at this point in the history
  20. fix a couple of paddings in the menu

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3cb5f32 View commit details
    Browse the repository at this point in the history
  21. make linter and formatter happy

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    08846c7 View commit details
    Browse the repository at this point in the history
  22. make the formatter happy

    morgillo authored and hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    fdcd6b1 View commit details
    Browse the repository at this point in the history
  23. add not-editable ComboBox to Standalone

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    dc65913 View commit details
    Browse the repository at this point in the history
  24. fix focus on not-editable ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    86e573c View commit details
    Browse the repository at this point in the history
  25. rearrange ComboBox params to make ktlint happy

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    640d4d4 View commit details
    Browse the repository at this point in the history
  26. update API files

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4a1b6ef View commit details
    Browse the repository at this point in the history
  27. fix single line on not-editable ComboBox

    reference: #601 (review)
    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d724bf8 View commit details
    Browse the repository at this point in the history
  28. prevent the ComboBox from expanding

    reference: #601 (review)
    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    531f650 View commit details
    Browse the repository at this point in the history
  29. iterate on colors

    reference: #601 (comment)
    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    82d844d View commit details
    Browse the repository at this point in the history
  30. address a couple of feedbacks

    reference: #601 (comment)
    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2bebaf9 View commit details
    Browse the repository at this point in the history
  31. iterate on focus management on ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5093088 View commit details
    Browse the repository at this point in the history
  32. reformat and update API files

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e60316b View commit details
    Browse the repository at this point in the history
  33. fix focus on click for not-editable ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ffc9d8a View commit details
    Browse the repository at this point in the history
  34. inline a few variables to reduce clutter

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7cd340d View commit details
    Browse the repository at this point in the history
  35. add different states for different ComboBoxes

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d5886db View commit details
    Browse the repository at this point in the history
  36. reformat things

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d015f6a View commit details
    Browse the repository at this point in the history
  37. introduce ComboBoxStyle

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3b6340b View commit details
    Browse the repository at this point in the history
  38. restore DropdownStyle

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    26b7e35 View commit details
    Browse the repository at this point in the history
  39. split ComboBoxes states in Standalone sample

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8408202 View commit details
    Browse the repository at this point in the history
  40. tune old DropDown style for IDE

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a97dc3f View commit details
    Browse the repository at this point in the history
  41. tune ComboBox focus once more

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b81bc6d View commit details
    Browse the repository at this point in the history
  42. update API files

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ec4c42d View commit details
    Browse the repository at this point in the history
  43. fix ComboBox popup expand

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    be28e9d View commit details
    Browse the repository at this point in the history
  44. remove focused padding for ComboBox divider

    It's not happening in the IDE sample
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0655d6b View commit details
    Browse the repository at this point in the history
  45. iterate on ComboBox focus

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5ee4716 View commit details
    Browse the repository at this point in the history
  46. iterate on ComboBox focus

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d325da6 View commit details
    Browse the repository at this point in the history
  47. add ui-tests module

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    458b8dc View commit details
    Browse the repository at this point in the history
  48. start adding tests to ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a1f2679 View commit details
    Browse the repository at this point in the history
  49. add more tests for ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    2c8c5c6 View commit details
    Browse the repository at this point in the history
  50. massive WIP commit because I'm getting paranoid

    I know there is IntelliJ local history. Give me a break!
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    bf61e59 View commit details
    Browse the repository at this point in the history
  51. clean up and initial restoration of ComboBox features

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f105f14 View commit details
    Browse the repository at this point in the history
  52. rework ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0fa6d3c View commit details
    Browse the repository at this point in the history
  53. add enabled/disabled chevron click tests

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4c8ac1f View commit details
    Browse the repository at this point in the history
  54. add click management to chevron

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e6ca70c View commit details
    Browse the repository at this point in the history
  55. fix popup open/close when not-editable

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0711544 View commit details
    Browse the repository at this point in the history
  56. add another batch of tests for ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b350a4d View commit details
    Browse the repository at this point in the history
  57. add maxPopupHeight to ComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    907d9c0 View commit details
    Browse the repository at this point in the history
  58. add onPopupStateChange

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b2a5941 View commit details
    Browse the repository at this point in the history
  59. extract NotEditableComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7b07d21 View commit details
    Browse the repository at this point in the history
  60. iterate on ListComboBox item selection

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    227e900 View commit details
    Browse the repository at this point in the history
  61. improve TAB navigation on NotEditableComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    cd46735 View commit details
    Browse the repository at this point in the history
  62. update IDE plugin example

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    ab047bb View commit details
    Browse the repository at this point in the history
  63. reformat SwingComparisonTabPanel

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a56836d View commit details
    Browse the repository at this point in the history
  64. iterate on ListComboBox scroll

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    699752b View commit details
    Browse the repository at this point in the history
  65. remove debug border

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e065529 View commit details
    Browse the repository at this point in the history
  66. reuse PointerInputScope.detectPressAndCancel

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    baa31eb View commit details
    Browse the repository at this point in the history
  67. extract PopupContainerStyle

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    a24e6c4 View commit details
    Browse the repository at this point in the history
  68. iterate on IntUiBridge.SimpleListItemStyle

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    176966e View commit details
    Browse the repository at this point in the history
  69. update API files

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e2f0f55 View commit details
    Browse the repository at this point in the history
  70. ensure 100% tests are passing

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    efb72ee View commit details
    Browse the repository at this point in the history
  71. move ListComboBox item selection with hover

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    e8e0962 View commit details
    Browse the repository at this point in the history
  72. iterate on hover and selection for SimpleListItem

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    aa4f5a8 View commit details
    Browse the repository at this point in the history
  73. have Esc to close an open popup

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6c4e4a3 View commit details
    Browse the repository at this point in the history
  74. iterate on ListComboBox height

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    74f1117 View commit details
    Browse the repository at this point in the history
  75. fix SimpleListItemColors.dark background color

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    87a4c1e View commit details
    Browse the repository at this point in the history
  76. iterate on Enter key press

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    aff22d9 View commit details
    Browse the repository at this point in the history
  77. close popup on click

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    50ef63b View commit details
    Browse the repository at this point in the history
  78. fix *ComboBox arrow and arrow area size

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    6889f89 View commit details
    Browse the repository at this point in the history
  79. remove unnecessary box

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    030c569 View commit details
    Browse the repository at this point in the history
  80. Update ktlint plugin config to also support 0.25 beta

    They changed the config and didn't implement a migration of the old
    config to the new config 🤦
    rock3r authored and hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    69c2e90 View commit details
    Browse the repository at this point in the history
  81. Cleanup code and refactor

    Stuff is still broken, maybe more than before :P
    rock3r authored and hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    4073dda View commit details
    Browse the repository at this point in the history
  82. Remove duplicated focused handling

    rock3r authored and hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d033cae View commit details
    Browse the repository at this point in the history
  83. Rename flag in ComboBox

    rock3r authored and hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b5e3b8d View commit details
    Browse the repository at this point in the history
  84. Remove Text from EditableComboBox

    rock3r authored and hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    06d7670 View commit details
    Browse the repository at this point in the history
  85. Fix KotlinC woes

    rock3r authored and hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    f00e025 View commit details
    Browse the repository at this point in the history
  86. Fix chevron alignment in EditableComboBox

    rock3r authored and hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    64b6ba6 View commit details
    Browse the repository at this point in the history
  87. restore basic onHover behavior for ListComboBox

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    3cef1d5 View commit details
    Browse the repository at this point in the history
  88. fix missing plugin in :ui-tests

    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7bf681d View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Fix missing ⬇️ event on editable ComboBox (#635)

    * rename a bunch of lambdas to make the linter happy
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    
    * Fix #632
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    
    * stitch broken tests
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    
    * update API files
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    
    * stitch IDE sample
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    
    * make the formatter happy
    
    * renamed a bunch of lambdas and shushed the linter
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    
    * format EditableComboBox
    
    * improve test for disabled ComboBox
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    
    ---------
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    Co-authored-by: morgillo <[email protected]>
    hamen and morgillo authored Oct 17, 2024
    Configuration menu
    Copy the full SHA
    12f04a0 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Remove rounderd corner from SimpleListItemStyle in bridge (#651)

    * remove rounded corner from IntUiBridge SimpleListItemMetrics
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    
    * make the formatter happy
    
    ---------
    
    Signed-off-by: Ivan Morgillo <[email protected]>
    hamen authored Oct 21, 2024
    Configuration menu
    Copy the full SHA
    97934c2 View commit details
    Browse the repository at this point in the history