Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: return value in Roblox platform notification handler #910

Merged
merged 2 commits into from
Feb 1, 2025

Conversation

lopi-py
Copy link
Contributor

@lopi-py lopi-py commented Jan 25, 2025

for (auto& workspace : workspaceFolders)
{
if (workspace->platform && workspace->platform->handleNotification(method, params))
return;
}
client->sendLogMessage(lsp::MessageType::Warning, "unknown notification method: " + method);

We don't return true so we still hit "unknown notification method" even if handled

@JohnnyMorganz
Copy link
Owner

I think we need to be cautious here since this early return will stop multiple workspace folders from working. Before, it would update the plugin data for all workspace folders, but after your change it will stop after the first workspace folder, and not update the others

@lopi-py
Copy link
Contributor Author

lopi-py commented Jan 27, 2025

Indeed, I have updated it

Copy link
Owner

@JohnnyMorganz JohnnyMorganz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JohnnyMorganz JohnnyMorganz merged commit 50e305b into JohnnyMorganz:main Feb 1, 2025
14 checks passed
JohnnyMorganz added a commit that referenced this pull request Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants