[AUTO] JuliaFormatter.jl run

[github-actions]

Automated changes by create-pull-request GitHub action

[JoshuaLampert]

Out of curiosity: Why did you opt for these automated format PRs instead of having the formatter as a separate CI run? This way you could guarantee that no unformatted source gets merged and you wouldn't need the auto-PRs. If you don't want the creator of a PR have to run the formatter locally, there exists https://github.com/julia-actions/julia-format, which makes suggestions to the PR based on the formatter.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.05%. Comparing base (2dfd258) to head (896b60b).

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #964   +/-   ##
=======================================
  Coverage   89.05%   89.05%           
=======================================
  Files         178      178           
  Lines        5473     5473           
=======================================
  Hits         4874     4874           
  Misses        599      599           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[juliohm]

We didn't know these format suggestions could be applied directly to PRs by a bot. If you can submit a PR with this alternative workflow, we can review and merge.

Thanks for all these suggestions of improvement.

[JoshuaLampert]

Ok, I can try a PR, but this is not number one on my list, so give me some time :)

[JoshuaLampert]

Ok, I can try a PR, but this is not number one on my list, so give me some time :)

I just had a look at this and I want to note that the clickable suggestions only work for PRs not from a fork. For PRs from a fork, the git diffs are still shown in the PR as a warning, but cannot be applied directly, cf. JuliaDiff/ChainRulesCore.jl#489. See https://github.com/Astroshaper/AsteroidThermoPhysicalModels.jl/pull/107/files for an example of how this would look like for PRs from a fork. This means that for forks, one would still need to run the formatter locally.
Do you still prefer this option, @juliohm?

[juliohm]

I believe it is an improvement. Warnings can be fixed by the PR authors before merging at least. Thanks for checking this! Em seg., 29 de jul. de 2024, 12:17, Joshua Lampert ***@***.***> escreveu:

…

Ok, I can try a PR, but this is not number one on my list, so give me some time :) I just had a look at this and I want to note that the clickable suggestions only work for PRs not from a fork. For PRs from a fork, the git diffs are still shown in the PR as a warning, but cannot be applied directly, cf. JuliaDiff/ChainRulesCore.jl#489 <JuliaDiff/ChainRulesCore.jl#489>. See https://github.com/Astroshaper/AsteroidThermoPhysicalModels.jl/pull/107/files for an example of how this would look like for PRs from a fork. This means that for forks, one would still need to run the formatter locally. Do you still prefer this option, @juliohm <https://github.com/juliohm>? — Reply to this email directly, view it on GitHub <#964 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZQW3JO2UISACGDG5BB62TZOZMJ3AVCNFSM6AAAAABLTA2OSCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJWGIYTQNZTGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[JoshuaLampert]

I created #965.