-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use julia-format action #965
Use julia-format action #965
Conversation
Hm, I wanted to check if the annotations work, but unfortunately it looks like there are no annotations. I don't know why, especially because reviewdog promised to do so:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
=======================================
Coverage 89.07% 89.07%
=======================================
Files 178 183 +5
Lines 5483 5483
=======================================
Hits 4884 4884
Misses 599 599 ☔ View full report in Codecov by Sentry. |
@JoshuaLampert I see the format error showing up nicely. Should we fix the code style and see the action turning green again? |
...wait what exactly do you see? Do you see an annotation like here? Because I don't see that, but I would like to see it. |
Yes, I would have hoped for a bit more visibility and easier to read suggestions. In principle this should work like in the PR I linked above, but I don't know why this is not the case here. Maybe the bot needs some privileges? |
I think this is already an improvement. We can experiment the new action and figure out missing permissions later. I will fix the code style and wait the tests again. |
As discussed in #964 (comment) this uses the julia-format action, which makes suggestions in a PR based on the formatter instead of creating PRs. This should reduce the noise and guarantees that no non-formatting PRs are merged.
Note, however, that clickable suggestions in the PR are only made for PRs that don't come from forks. For PRs from forks only warnings with the corresponding diff from the formatter are shown (due to privilege issues).