Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[proxTV] Recompile with -O3 and include headers in the JLL #9365

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[proxTV] Recompile with -O3 and include headers in the JLL #9365

merged 1 commit into from
Sep 4, 2024

Conversation

amontoison
Copy link
Contributor

@amontoison amontoison commented Sep 3, 2024 •
edited
Loading

@nathanemac
I also added some

#ifdef __cplusplus
extern "C" {
#endif
...
#ifdef __cplusplus
}
#endif

such that we can easily generate wrappers with Clang.jl.

@amontoison amontoison enabled auto-merge (squash) September 3, 2024 23:57
@amontoison amontoison merged commit f5e0f7c into JuliaPackaging:master Sep 4, 2024
19 checks passed
@amontoison amontoison deleted the proxtv_upgrade branch September 4, 2024 00:04
dpo
dpo reviewed Sep 6, 2024
View reviewed changes
P/proxTV/build_tarballs.jl

# Collection of sources required to build proxTV.
sources = [
GitSource("https://github.com/albarji/proxTV", "0b8973cd7e1a2348c842393f689949eeebc9f654"),
GitSource("https://github.com/amontoison/proxTV", "6f7ad7e1048a6d97aa1e92ec35937ae4f155b1a0"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amontoison This is no longer the official repository. Did you submit your changes to the original proxTV?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to submit the changes.
I opened this PR: albarji/proxTV#62

Otherwise, we can't use proxTV in Julia.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpo dpo dpo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amontoison @dpo