Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proxTV] Recompile with -O3 and include headers in the JLL #9365

Merged
merged 1 commit into from
Sep 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions P/proxTV/build_tarballs.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,26 +2,27 @@ using BinaryBuilder, Pkg
using Base.BinaryPlatforms

name = "proxTV"
version = v"3.3.0"
version = v"3.3.1"

# Collection of sources required to build proxTV.
sources = [
GitSource("https://github.com/albarji/proxTV", "0b8973cd7e1a2348c842393f689949eeebc9f654"),
GitSource("https://github.com/amontoison/proxTV", "6f7ad7e1048a6d97aa1e92ec35937ae4f155b1a0"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amontoison This is no longer the official repository. Did you submit your changes to the original proxTV?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to submit the changes.
I opened this PR: albarji/proxTV#62

Otherwise, we can't use proxTV in Julia.

]

# Bash recipe for building across all platforms
# We build manually because the default build system
# is Python's setuptools.
script = raw"""
cd $WORKSPACE/srcdir/proxTV/src
cp *.h ${includedir}

if [[ "${target}" == *mingw* ]]; then
LBT="${libdir}/libblastrampoline-5.dll"
else
LBT="-lblastrampoline"
fi

${CXX} -DNOMATLAB -c -fPIC -I${includedir} *.cpp
${CXX} -DNOMATLAB -c -fPIC -O3 -I${includedir} *.cpp
${CXX} -shared -o libproxtv.${dlext} ${LBT} *.o

install -Dvm 755 libproxtv.${dlext} -t ${libdir}
Expand Down