Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring #235

Merged
merged 8 commits into from
Mar 12, 2019
Merged

Refactoring #235

merged 8 commits into from
Mar 12, 2019
+350 −202

Conversation

tkf
Copy link
Member

@tkf tkf commented Feb 17, 2019

as outlined in #199

@tkf tkf force-pushed the refactoring branch 2 times, most recently from 9aede50 to 685024b Compare February 18, 2019 01:31
@tkf tkf marked this pull request as ready for review February 18, 2019 01:34
This was referenced Feb 18, 2019
Merged
Merged
@coveralls
Copy link

coveralls commented Feb 18, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 549

  • 116 of 134 (86.57%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 76.019%
Changes Missing Coverage Covered Lines Changed/Added Lines %
julia/with_rebuilt.py 1 4 25.0%
julia/core.py 115 130 88.46%
Files with Coverage Reduction New Missed Lines %
julia/core.py 4 82.97%
Totals Coverage Status
Change from base Build 546: 0.7%
Covered Lines: 653
Relevant Lines: 859
💛 - Coveralls

3 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 549

  • 116 of 134 (86.57%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 76.019%
Changes Missing Coverage Covered Lines Changed/Added Lines %
julia/with_rebuilt.py 1 4 25.0%
julia/core.py 115 130 88.46%
Files with Coverage Reduction New Missed Lines %
julia/core.py 4 82.97%
Totals Coverage Status
Change from base Build 546: 0.7%
Covered Lines: 653
Relevant Lines: 859
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 549

  • 116 of 134 (86.57%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 76.019%
Changes Missing Coverage Covered Lines Changed/Added Lines %
julia/with_rebuilt.py 1 4 25.0%
julia/core.py 115 130 88.46%
Files with Coverage Reduction New Missed Lines %
julia/core.py 4 82.97%
Totals Coverage Status
Change from base Build 546: 0.7%
Covered Lines: 653
Relevant Lines: 859
💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 549

  • 116 of 134 (86.57%) changed or added relevant lines in 2 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 76.019%
Changes Missing Coverage Covered Lines Changed/Added Lines %
julia/with_rebuilt.py 1 4 25.0%
julia/core.py 115 130 88.46%
Files with Coverage Reduction New Missed Lines %
julia/core.py 4 82.97%
Totals Coverage Status
Change from base Build 546: 0.7%
Covered Lines: 653
Relevant Lines: 859
💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 18, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build 552

  • 120 of 137 (87.59%) changed or added relevant lines in 3 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.9%) to 76.218%
Changes Missing Coverage Covered Lines Changed/Added Lines %
julia/with_rebuilt.py 1 4 25.0%
julia/core.py 118 132 89.39%
Files with Coverage Reduction New Missed Lines %
julia/core.py 4 83.29%
Totals Coverage Status
Change from base Build 546: 0.9%
Covered Lines: 657
Relevant Lines: 862
💛 - Coveralls

tkf added 3 commits February 17, 2019 18:59
@tkf
Add LibJulia.load
c9676a6
@tkf
Add docstring for JuliaInfo and LibJulia
6c8759b
@tkf
Export API through julia.api namespace
a6eae4d 
There could be a package called, e.g., LibJulia.  Let's avoid using
`julia.CamelCase` namespace.
@tkf tkf merged commit a6eae4d into JuliaPy:master Mar 12, 2019
@tkf tkf mentioned this pull request Mar 23, 2019
Closed
@tkf tkf deleted the refactoring branch March 23, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkf @coveralls