Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Change in Parameter Extraction on Parameters on CFFParser #58

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Minor Change in Parameter Extraction on Parameters on CFFParser #58

wants to merge 2 commits into from

Commits on Sep 21, 2017

  1. Minor Change in Predicate Extraction on Parameters 

    This is a minor modification to the CFFPlanParser to include more general cases covered by PDDL 2.1. The planner was able to give a valid plan but the parser would not work correctly. The earliest version identifies the predicate by locating its type. So it always should have a type after every predicate, in other to work. 
For example it would work in:
:parameters (?q - robot ?wayp - waypoint ?wayp2 - waypoint )

But not in:
:parameters (?q - robot ?wayp ?wayp2 - waypoint )   or   :parameters (?q ?wayp ?wayp2) 

The proposed version uses the same original structure but identify the predicate by locating the "?"
    @nogueiravinicius
    nogueiravinicius authored Sep 21, 2017
    Configuration menu
    Copy the full SHA
    bc2b13b View commit details
    Browse the repository at this point in the history

  2. Update CFFPlanParser.cpp 

    This is a minor modification to the CFFPlanParser to include more general cases covered by PDDL 2.1. The planner was able to give a valid plan but the parser would not work correctly. The earliest version identifies the parameter by locating its type. So it always should have a type after every parameter, in other to work. 
For example it would work in:
:parameters (?q - robot ?wayp - waypoint ?wayp2 - waypoint )

But not in:
:parameters (?q - robot ?wayp ?wayp2 - waypoint )   or   :parameters (?q ?wayp ?wayp2) 

The proposed version uses the same original structure but identify the parameter by locating the "?"
    @nogueiravinicius
    nogueiravinicius authored Sep 21, 2017
    Configuration menu
    Copy the full SHA
    5068003 View commit details
    Browse the repository at this point in the history