Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the way messages are exchanged between server and client (msgpack + chunking) #153

Merged
merged 3 commits into from
Apr 10, 2024
Merged

Rework the way messages are exchanged between server and client (msgpack + chunking) #153

merged 3 commits into from
Apr 10, 2024

Conversation

alesgenova
Copy link
Member

  • Use msgpack for serialization of the messages between server and client
    • slightly reduced message size
    • binary values can directly be in the object serialized/deserialized (no need to use previous attachment mechanism)
  • Chunk messages
    • avoids the websocket connection to close unexpectedly when a large message is exchanged
    • use existing environmental variable WSLINK_MAX_MSG_SIZE to determine the chunk size

@jourdain
Copy link
Collaborator

jourdain commented Apr 8, 2024

I haven't looked at the code yet. But make sure your commit is marked with BREAKING CHANGE: ....

jourdain
jourdain approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@jourdain jourdain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not tested yet but the code looks good.

@jourdain jourdain merged commit 897ece7 into Kitware:master Apr 10, 2024
6 checks passed
@jourdain
Copy link
Collaborator

Tested and it looks good

@jourdain
Copy link
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ajain-work ajain-work mentioned this pull request May 10, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jourdain jourdain jourdain approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alesgenova @jourdain