Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual GLEEC #564

Closed
wants to merge 9 commits into from
Closed

Dual GLEEC #564

wants to merge 9 commits into from

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Aug 23, 2024

  • Removes VOTE2024
  • Updates komodod to 0adeeab
  • Updates mm2 to latest release

@smk762 smk762 requested review from gcharang, DeckerSU and cipig August 23, 2024 14:18
@DeckerSU
Copy link
Contributor

DeckerSU commented Aug 26, 2024

As far as I know (@ca333 can correct me if I'm wrong), GLEEC wants to keep both chains notarized for now. So, we should have both the old GLEEC and the new GLEEC running simultaneously. However, since two chains with the same "ticker" (GLEEC) can't exist at the same time due to data folder conflicts, my suggestion is to move the old chain to the GLEEC.old folder while the new chain remains in the standard GLEEC folder.

The old chain would need to be launched with the -datadir argument, pointing to GLEEC.old. Additionally, we may need to differentiate the coin files, using GLEEC.old_7776 for the old GLEEC and GLEEC_7776 for the new one.

@DeckerSU
Copy link
Contributor

It might also be a good idea to separate the komodod update from the GLEEC introduction. The komodod update should be the priority right now, so we can start that process to ensure that every NN is updated in time. We can then handle the GLEEC preparations in a separate PR.

Copy link
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also noticed that the new iguana/coins/gleec_7776 file for the new GLEEC contains an incorrect netmagic value. I’m not sure if Iguana actively uses it, but here are the parameters once again for checking/comparison:

OLD:

docker run --rm deckersu/komodo-chainparams:latest -ac_name=GLEEC -ac_supply=210000000 -ac_public=1 -ac_staked=100 | jq .
{
  "chainname": "GLEEC",
  "magic": 1824725725,
  "magic_bytes": "dd1ac36c",
  "magic_hex": "6cc31add",
  "p2pport": 23225,
  "rpcport": 23226
}

NEW:

docker run --rm deckersu/komodo-chainparams:latest -ac_name=GLEEC -ac_supply=1000000000 -ac_end=1 -ac_public=1 -ac_staked=50 | jq .
{
  "chainname": "GLEEC",
  "magic": 1193402844,
  "magic_bytes": "dce12147",
  "magic_hex": "4721e1dc",
  "p2pport": 23344,
  "rpcport": 23345
}

@smk762 smk762 requested a review from DeckerSU August 27, 2024 09:28
Copy link
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR simply replaces the old GLEEC with the new GLEEC, instead of keeping both—you can see the details here.

@ca333 We should keep both GLEEC chains notarized, right?

@ca333
Copy link
Contributor

ca333 commented Aug 27, 2024

The PR simply replaces the old GLEEC with the new GLEEC, instead of keeping both—you can see the details here.

@ca333 We should keep both GLEEC chains notarized, right?

yes, both chains will remain active / dPoW protected.

Once Gleec "sunsets" GLEEC-OLD we ll update things accordingly. But that will likely take some time.

Copy link
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GLEEC and GLEEC_OLD should be running on the main server. This restriction is related to komodod, as the old GLEEC chain is a regular AC and cannot follow the notarisations (checkpoints) set by 3P nodes since komodod only has mainnet nodes' pubkeys hardcoded. Therefore, if we run it as suggested in this PR, it will not be protected by dPoW. To ensure proper protection, we need to run it as proposed here on mainnet servers with a separate data folder specified by -datadir.

Additionally, I highly recommend separating the GLEEC update from the komodod update. The komodod update is crucial and needs to be implemented as soon as possible, and it's ready to go. Therefore, my suggestion is to remove all GLEEC-related changes from this PR and open a separate PR for the GLEEC update after the komodod update is completed on all nodes.

@smk762 smk762 changed the base branch from master to dev August 29, 2024 07:37
@smk762 smk762 changed the title update komodod, replace gleec, rm vote Dual GLEEC Aug 29, 2024
@smk762 smk762 marked this pull request as draft August 29, 2024 07:37
@smk762 smk762 mentioned this pull request Aug 29, 2024
@smk762 smk762 closed this Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants