-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dual GLEEC #564
Dual GLEEC #564
Conversation
As far as I know (@ca333 can correct me if I'm wrong), GLEEC wants to keep both chains notarized for now. So, we should have both the old GLEEC and the new GLEEC running simultaneously. However, since two chains with the same "ticker" ( The old chain would need to be launched with the |
It might also be a good idea to separate the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also noticed that the new iguana/coins/gleec_7776 file for the new GLEEC contains an incorrect netmagic value. I’m not sure if Iguana actively uses it, but here are the parameters once again for checking/comparison:
OLD:
docker run --rm deckersu/komodo-chainparams:latest -ac_name=GLEEC -ac_supply=210000000 -ac_public=1 -ac_staked=100 | jq .
{
"chainname": "GLEEC",
"magic": 1824725725,
"magic_bytes": "dd1ac36c",
"magic_hex": "6cc31add",
"p2pport": 23225,
"rpcport": 23226
}
NEW:
docker run --rm deckersu/komodo-chainparams:latest -ac_name=GLEEC -ac_supply=1000000000 -ac_end=1 -ac_public=1 -ac_staked=50 | jq .
{
"chainname": "GLEEC",
"magic": 1193402844,
"magic_bytes": "dce12147",
"magic_hex": "4721e1dc",
"p2pport": 23344,
"rpcport": 23345
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR simply replaces the old GLEEC with the new GLEEC, instead of keeping both—you can see the details here.
@ca333 We should keep both GLEEC chains notarized, right?
yes, both chains will remain active / dPoW protected. Once Gleec "sunsets" GLEEC-OLD we ll update things accordingly. But that will likely take some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GLEEC
and GLEEC_OLD
should be running on the main
server. This restriction is related to komodod
, as the old GLEEC chain is a regular AC and cannot follow the notarisations (checkpoints) set by 3P nodes since komodod
only has mainnet nodes' pubkeys hardcoded. Therefore, if we run it as suggested in this PR, it will not be protected by dPoW. To ensure proper protection, we need to run it as proposed here on mainnet servers with a separate data folder specified by -datadir
.
Additionally, I highly recommend separating the GLEEC update from the komodod
update. The komodod
update is crucial and needs to be implemented as soon as possible, and it's ready to go. Therefore, my suggestion is to remove all GLEEC-related changes from this PR and open a separate PR for the GLEEC update after the komodod
update is completed on all nodes.
komodod
to0adeeab