Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update komodod & KDF #565

Merged
merged 22 commits into from
Aug 30, 2024
Merged

Update komodod & KDF #565

merged 22 commits into from
Aug 30, 2024

Conversation

smk762
Copy link
Collaborator

@smk762 smk762 commented Aug 29, 2024

Removes VOTE2024
Updates komodod to 0adeeab
Updates mm2 to latest release

@smk762 smk762 changed the title Update/komodod Update komodod & KDF Aug 29, 2024
@smk762 smk762 requested review from gcharang and DeckerSU August 29, 2024 07:42
@smk762 smk762 mentioned this pull request Aug 29, 2024
pkill -9 iguana
cd iguana
./m_notary_build
./m_notary_main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add a comment here that ./m_notary_main should be launched for mainnet nodes and ./m_notary_3rdparty for third-party nodes only. Operators should launch the corresponding file based on the node type, meaning they should not run both files in sequence on the same node.

iguana/m_notary_3rdparty Outdated Show resolved Hide resolved
iguana/m_notary_3rdparty Outdated Show resolved Hide resolved
@DeckerSU
Copy link
Contributor

Also I guess we should include the following "HOW-TO" about error in HDD data. And it's especially important to emphasize to the NN operators that service disruptions are unacceptable. If you experience the error in HDD data error for any chain, you should sync from another node and then bootstrap without stopping the production node for an extended period. The bootstrap process should only take a few minutes, and this is the expected downtime.

HOW-TO

If your blockchain data folder contains data from an older daemon version (before we switched to the 0.7.x versioning, such as 3.x.x), you might encounter this error when starting the 0.9.0 daemon:

2024-08-21 18:49:12 ERROR: LoadBlockIndex() : failed to read value
2024-08-21 18:49:12 : Error loading block database.
error in HDD data, might just need to update to latest, if that doesn't work, then you need to resync.

In this case, you have several options:

  1. Resync from scratch (slowest but most accurate, allowing your node to recalculate value pools).
  2. Bootstrap from dexstats.info (fastest, but since the initial sync version is unknown, value pools might be incorrectly calculated). Value pools refer to the stats for transparent, sprout, sapling, and burned chain values.
  3. Reindex with -reindex, but options (1) and (2) are recommended.

Future upgrades shouldn’t have these issues, but for now, we should recommend that users who encounter the error in HDD data error after updating resync their nodes. This error seems to affect "veteran nodes" with data written by older daemon versions. Nodes that were on 0.8.2 or synced from scratch with this or a newer version should update smoothly.

p.s. To simplify the upgrade process, we also offer (optional) this script: restart_kmd_daemons.sh. Just run it on a host with launched Komodo daemons within a directory containing the new version of komodod and komodo-cli, and all launched instances will be stopped and re-launched with the new version of the daemon. Very convenient!

@DeckerSU
Copy link
Contributor

It seems the only thing left to fix is this:

dPoW/doc/update0716.md

Lines 73 to 74 in 3b41c6a

./m_notary_main
./m_notary_3rdparty

It shouldn't be interpreted by operators as a single sequence of commands.

DeckerSU

This comment was marked as outdated.

Copy link
Contributor

@DeckerSU DeckerSU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the latest changes, LGTM.

@smk762 smk762 merged commit 6fa3ce0 into dev Aug 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants