Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use https instead of ssh in .gitmodules #450

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

shermanlo77
Copy link

Semi-reverts a397177

The submodules are public so requiring ssh keys is unnecessary. This will make building AlphaPulldown in a container easier

@jkosinski
Copy link
Collaborator

@DimaMolod I agree, https is less problematic. Any advantage of using ssh?

@DimaMolod
Copy link
Collaborator

DimaMolod commented Nov 5, 2024

@jkosinski @shermanlo77 what exactly is problematic about ssh? With https I can't push to submodules repos from command line due to the new github security/2fa and it is not very convenient to commit always from browser. That is my only motivation

@jkosinski
Copy link
Collaborator

If I remember correctly, with https users can just clone without any password or ssh key, while with ssh this is required. Am I correct @shermanlo77 ?

@shermanlo77
Copy link
Author

Thanks for the questions

With https, passwords or ssh keys are not required when git cloning the public submodules. This is useful if I want to build AlphaPulldown in a container, where it is its own isolated system. This can also benefit those on HPC systems so they can git clone without having to forward keys or having a GitHub account.

With ssh, I have to provide ssh keys which is unnecessary given the submodules are public. If the submodules are private, then ssh would be fair.

I'm aware the requirement of ssh keys is stated in the README for developers

0.5. Installation for developers
Only for the developers who would like to modify AlphaPulldown's codes and test their modifications. Please add your SSH key to your GitHub account

@DimaMolod If you want to push commits within a submodule using a ssh remote instead of a https remote, have you tried changing the URL of the remote?

For example

cd alphafold
git remote set-url origin [email protected]:KosinskiLab/alphafold.git

This should leave the file .gitmodules unaffected but now you should be able to push commits with ssh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants