Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm manifests template based #904

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Oct 3, 2024

What

Helm manifests do not contain a namespace object. It is all delegated to the helm tool.

Discussion on Kuadrant/authorino-operator#202

Additionally, added verify ci test to ensure chart manifests are up to date

Verification steps

Preparation setup (pre-requisites)

make kind-create-cluster
make install-cert-manager

Add kuadrant helm repo for dependencies

helm repo add kuadrant https://kuadrant.io/helm-charts/ --force-update

Update dep to existing values (other than 0.0.0 in the code in main)

V="0.13.0" yq -i e '(.dependencies[] | select(.name == "authorino-operator").version) = strenv(V)' charts/kuadrant-operator/Chart.yaml
V="0.11.0" yq -i e '(.dependencies[] | select(.name == "limitador-operator").version) = strenv(V)' charts/kuadrant-operator/Chart.yaml
V="0.6.0" yq -i e '(.dependencies[] | select(.name == "dns-operator").version) = strenv(V)' charts/kuadrant-operator/Chart.yaml

Update deps

helm dependency build ./charts/kuadrant-operator/

Install helm charts

helm install kuadrant-operator ./charts/kuadrant-operator/ --namespace kuadrant-system --create-namespace

Check status

bin/helm status kuadrant-operator -n kuadrant-system

Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.23%. Comparing base (ece13e8) to head (3235ee5).
Report is 213 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #904      +/-   ##
==========================================
+ Coverage   80.20%   81.23%   +1.02%     
==========================================
  Files          64       89      +25     
  Lines        4492     6953    +2461     
==========================================
+ Hits         3603     5648    +2045     
- Misses        600      886     +286     
- Partials      289      419     +130     
Flag Coverage Δ
bare-k8s-integration 6.90% <ø> (?)
controllers-integration 72.82% <ø> (?)
envoygateway-integration 50.00% <ø> (?)
gatewayapi-integration 12.62% <ø> (?)
integration ?
istio-integration 53.73% <ø> (?)
unit 28.93% <ø> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 88.57% <100.00%> (+17.14%) ⬆️
api/v1beta2 (u) 81.25% <75.17%> (-10.18%) ⬇️
pkg/common (u) 88.13% <ø> (-0.70%) ⬇️
pkg/istio (u) 71.51% <ø> (-2.40%) ⬇️
pkg/log (u) 94.73% <ø> (ø)
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 85.39% <ø> (+5.93%) ⬆️
controllers (i) 82.61% <82.51%> (+5.81%) ⬆️

see 52 files with indirect coverage changes

@eguzki eguzki marked this pull request as ready for review October 3, 2024 14:45
Copy link
Collaborator

@didierofrivia didierofrivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖼️

@eguzki eguzki merged commit 8265e10 into main Oct 3, 2024
33 of 34 checks passed
@eguzki eguzki deleted the helm-manifest-templated-namespace branch October 3, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants