made it to where lift can not go up if the limit switch hasn't been p… #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reediculous456
requested changes
Mar 18, 2024
| if (leftLimitSwitch.isPressed() && leftLiftEncoder.getPosition() != 0) { | ||
| leftLiftEncoder.setPosition(0); | ||
| if (leftLimitSwitch.isPressed()) { | ||
| if (leftLimitSwitchBeenPressed == false) { |
There was a problem hiding this comment.
I think we can just do switchPressed = true every time the switch is pressed, add this if statement adds lines of code but doesn’t change the outcome. In other words, I would put this back as it was and only add the setting of the Boolean var to the existing if statement
Griffin9881
deleted the
132-fix-lift-from-going-up-if-it-hasnt-hit-limit-switch
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ressed
Pull Request
Issue Number
Closes #132
Comments