Check multiplication overflow in ValidateEncodingParams
#1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anupsv
reviewed
Feb 28, 2025
anupsv
approved these changes
Mar 4, 2025
jianoaix
approved these changes
Mar 4, 2025
| @@ -11,6 +11,8 @@ var ( | |||
| ErrInvalidParams = errors.New("invalid encoding params") | |||
| ) | |||
|
|
|||
| const maxUint64 = ^uint64(0) | |||
There was a problem hiding this comment.
just use existing constant math.MaxUint64 should be sufficient
| @@ -61,6 +63,9 @@ func GetNumSys(dataSize uint64, chunkLen uint64) uint64 { | |||
|
|
|||
| // ValidateEncodingParams takes in the encoding parameters and returns an error if they are invalid. | |||
| func ValidateEncodingParams(params EncodingParams, SRSOrder uint64) error { | |||
| if params.ChunkLength != 0 && params.NumChunks > maxUint64/params.ChunkLength { | |||
There was a problem hiding this comment.
should it check if ChunkLength / NumChunks are 0 as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Ensure that
params.ChunkLength*params.NumChunksdoesn't result in overflowChecks