Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check multiplication overflow in ValidateEncodingParams #1341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check multiplication overflow in ValidateEncodingParams #1341

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions encoding/params.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ var (
ErrInvalidParams = errors.New("invalid encoding params")
)

const maxUint64 = ^uint64(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use existing constant math.MaxUint64 should be sufficient


type EncodingParams struct {
ChunkLength uint64 // ChunkSize is the length of the chunk in symbols
NumChunks uint64
Expand Down Expand Up @@ -61,6 +63,9 @@ func GetNumSys(dataSize uint64, chunkLen uint64) uint64 {

// ValidateEncodingParams takes in the encoding parameters and returns an error if they are invalid.
func ValidateEncodingParams(params EncodingParams, SRSOrder uint64) error {
if params.ChunkLength != 0 && params.NumChunks > maxUint64/params.ChunkLength {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it check if ChunkLength / NumChunks are 0 as well?

return fmt.Errorf("multiplication overflow: ChunkLength: %d, NumChunks: %d", params.ChunkLength, params.NumChunks)
}

// Check that the parameters are valid with respect to the SRS. The precomputed terms of the amortized KZG
// prover use up to order params.ChunkLen*params.NumChunks-1 for the SRS, so we must have
Expand Down
Loading