forked from solana-labs/ledger-app-solana
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues found by sonarcloud #45
Draft
fbeutin-ledger
wants to merge
10
commits into
develop
Choose a base branch
from
wip/fbeutin/sonarcloud_suggestions_2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbeutin-ledger
force-pushed
the
wip/fbeutin/sonarcloud_suggestions_2
branch
from
October 12, 2022 17:23
e8df391
to
817d40a
Compare
fbeutin-ledger
force-pushed
the
wip/fbeutin/swap_rebase_post_refacto
branch
from
October 13, 2022 08:05
30c41f5
to
f131fe4
Compare
fbeutin-ledger
force-pushed
the
wip/fbeutin/swap_rebase_post_refacto
branch
from
October 27, 2022 13:53
b496de4
to
0918d87
Compare
fbeutin-ledger
force-pushed
the
wip/fbeutin/sonarcloud_suggestions_2
branch
from
November 16, 2022 10:14
817d40a
to
44eb43e
Compare
fbeutin-ledger
force-pushed
the
wip/fbeutin/swap_rebase_post_refacto
branch
5 times, most recently
from
January 25, 2023 12:47
5d1d63f
to
3893329
Compare
fbeutin-ledger
force-pushed
the
wip/fbeutin/swap_rebase_post_refacto
branch
5 times, most recently
from
February 1, 2023 19:25
4ae4e68
to
dec5919
Compare
Base automatically changed from
wip/fbeutin/swap_rebase_post_refacto
to
develop
April 18, 2023 13:55
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.