forked from solana-labs/ledger-app-solana
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues found by sonarcloud #45
Draft
fbeutin-ledger
wants to merge
10
commits into
develop
Choose a base branch
from
wip/fbeutin/sonarcloud_suggestions_2
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Commits on Oct 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 210dfa0 - Browse repository at this point
Copy the full SHA 210dfa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c49b4b - Browse repository at this point
Copy the full SHA 7c49b4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bbb514a - Browse repository at this point
Copy the full SHA bbb514aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a12689e - Browse repository at this point
Copy the full SHA a12689eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0918d87 - Browse repository at this point
Copy the full SHA 0918d87View commit details
Commits on Nov 16, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ae67375 - Browse repository at this point
Copy the full SHA ae67375View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c9f5c2 - Browse repository at this point
Copy the full SHA 6c9f5c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ad6201 - Browse repository at this point
Copy the full SHA 9ad6201View commit details -
Configuration menu - View commit details
-
Copy full SHA for 502794a - Browse repository at this point
Copy the full SHA 502794aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44eb43e - Browse repository at this point
Copy the full SHA 44eb43eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.