Push prerelease builds to new prerelease app #7986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 5 Skipped Deployments
|
angusbayley
force-pushed
the
support/new-nightly-app-id
branch
2 times, most recently
from
347fe47
to
1b1c64f
Compare
angusbayley
force-pushed
the
support/new-prerelease-app-id
branch
from
839dd9b
to
99da547
Compare
angusbayley
force-pushed
the
support/new-prerelease-app-id
branch
2 times, most recently
from
3055f56
to
672b374
Compare
themooneer
previously approved these changes
Oct 8, 2024
angusbayley
force-pushed
the
support/new-prerelease-app-id
branch
from
672b374
to
e612918
Compare
angusbayley
commented
Oct 8, 2024
| # This should come from env files - as we move each release type to its own app we will | ||
| # move them away from "Release" and to their own .env-file defined configuration | ||
| configuration: options[:nightly] ? ENV["APP_CONFIGURATION"] : "Release", | ||
| configuration: ENV["APP_CONFIGURATION"], |
There was a problem hiding this comment.
configuration is correctly set in .env files for this one 🥳
angusbayley
force-pushed
the
support/new-prerelease-app-id
branch
from
7ea9ee1
to
13b6af8
Compare
angusbayley
force-pushed
the
support/new-prerelease-app-id
branch
from
13b6af8
to
48fd2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changesetwas attached.📝 Description
A new app has been created in App Store Connect for prerelease builds. This PR specifies that prerelease builds should be sent to that app, by defining the following new properties during prerelease app build and testflight upload:
configuration:
"Prerelease"bundle id:
com.ledger.live.prereleaseapp identifier:
com.ledger.live.prereleaseThese correspond to a newly created configuration in Xcode and a newly created Identifier and Provisioning Profile in identities/developer portal.
One prerelease build has successfully been sent to this app - here's what it looks like in Testflight:
❓ Context
An extension of https://ledgerhq.atlassian.net/browse/LIVE-13485
🧐 Checklist for the PR Reviewers