Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push prerelease builds to new prerelease app #7986

Merged
merged 5 commits into from
Oct 9, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/ledger-live-mobile/fastlane/.env.ios.prerelease
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
ENVFILE=.env.ios.prerelease
APP_IDENTIFIER="com.ledger.live"
MY_APP_BUNDLE_ID="com.ledger.live"
APP_NAME="Ledger Live"
APP_IDENTIFIER="com.ledger.live.prerelease"
MY_APP_BUNDLE_ID="com.ledger.live.prerelease"
APP_NAME="LL PRERELEASE"
APP_CONFIGURATION="Prerelease"
SENTRY_ENVIRONMENT=prerelease
SENTRY_PROJECT=llm-ios-prerelease
1 change: 1 addition & 0 deletions apps/ledger-live-mobile/fastlane/.env.ios.release
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ ENVFILE=.env.ios.release
APP_IDENTIFIER="com.ledger.live"
MY_APP_BUNDLE_ID="com.ledger.live"
APP_NAME="Ledger Live"
APP_CONFIGURATION="Release"
SENTRY_ENVIRONMENT=release
SENTRY_PROJECT=llm-ios
1 change: 1 addition & 0 deletions apps/ledger-live-mobile/fastlane/.env.ios.staging
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,6 @@ ENVFILE=.env.ios.staging
APP_IDENTIFIER="com.ledger.live.dev"
MY_APP_BUNDLE_ID="com.ledger.live.dev"
APP_NAME="LL [STAGING]"
APP_CONFIGURATION="Release"
SENTRY_ENVIRONMENT=staging
SENTRY_PROJECT=llm-ios-staging
46 changes: 34 additions & 12 deletions apps/ledger-live-mobile/fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,18 @@ platform :ios do
keychain_password: ENV["CI_KEYCHAIN_PASSWORD"],
git_basic_authorization: Base64.strict_encode64("#{ENV["GIT_REPO_USER"]}:#{ENV["GH_TOKEN"]}"),
)
match(
type: "appstore",
app_identifier: "com.ledger.live.prerelease",
force: true,
generate_apple_certs: true,
git_url: ENV["GIT_REPO_URL"],
username: ENV["APPLE_ID"],
team_id: ENV["DEVELOPER_TEAM_ID"],
keychain_name: ENV["CI_KEYCHAIN_NAME"],
keychain_password: ENV["CI_KEYCHAIN_PASSWORD"],
git_basic_authorization: Base64.strict_encode64("#{ENV["GIT_REPO_USER"]}:#{ENV["GH_TOKEN"]}"),
)
end

desc "buid for deployment (app-store or ad-hoc)"
Expand All @@ -163,10 +175,9 @@ platform :ios do

build_number = latest_testflight_build_number(
version: trim_version_number(package["version"]),
# we are moving to using ENV["APP_IDENTIFIER"] but staging + prerelease still override their own
# app identifier to publish to com.ledger.live . This will be removed once we are are fully publishing
# to separate apps
app_identifier: options[:nightly] ? ENV["APP_IDENTIFIER"] : "com.ledger.live"
# we are moving to using ENV["APP_IDENTIFIER"] but staging still overrides its own app identifier to
# publish to com.ledger.live . This will be removed once we are are fully publishing to separate apps
app_identifier: !options[:adhoc] ? ENV["APP_IDENTIFIER"] : "com.ledger.live"
)

increment_build_number({
Expand Down Expand Up @@ -258,9 +269,7 @@ platform :ios do
gym(
scheme: PROJECT_NAME,
workspace: XCODE_WORKSPACE,
# This should come from env files - as we move each release type to its own app we will
#Β move them away from "Release" and to their own .env-file defined configuration
configuration: options[:nightly] ? ENV["APP_CONFIGURATION"] : "Release",
configuration: ENV["APP_CONFIGURATION"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuration is correctly set in .env files for this one πŸ₯³

silent: true,
xcargs: `#{settings_to_override} -UseNewBuildSystem=YES`,
output_directory: OUTPUT_DIRECTORY,
Expand Down Expand Up @@ -312,6 +321,19 @@ platform :ios do

UI.important("Another build is already in external beta review. Skipping external beta review submission")
end
elsif (options[:prerelease])
pilot(
skip_submission: false,
app_identifier: ENV["APP_IDENTIFIER"],
skip_waiting_for_build_processing: true,
ipa: IPA_DIRECTORY,
changelog: "Prerelease Build v#{package['version']} (#{build_number})",
beta_app_review_info: {
contact_email: "[email protected]",
contact_first_name: "Ledger Live",
notes: "test prerelease builds"
}
)
else
pilot(
skip_submission: true,
Expand All @@ -338,16 +360,16 @@ platform :ios do
lane :ci_testflight do |options|
setup_ios_ci
build(ci: true)
upload(ci: true)
upload(
prerelease: true,
ci: true
)
end

desc "ci: create nightly version"
lane :ci_nightly do |options|
setup_ios_ci
build(
nightly: true,
ci: true
)
build(ci: true)
upload(
nightly: true,
ci: true
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1132,6 +1132,123 @@
};
name = Nightly;
};
BB2FFDA12CAD600D00AB17D8 /* Prerelease */ = {
isa = XCBuildConfiguration;
buildSettings = {
ALWAYS_SEARCH_USER_PATHS = NO;
CLANG_ANALYZER_LOCALIZABILITY_NONLOCALIZED = YES;
CLANG_CXX_LANGUAGE_STANDARD = "c++20";
CLANG_CXX_LIBRARY = "libc++";
CLANG_ENABLE_MODULES = YES;
CLANG_ENABLE_OBJC_ARC = YES;
CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES;
CLANG_WARN_BOOL_CONVERSION = YES;
CLANG_WARN_COMMA = YES;
CLANG_WARN_CONSTANT_CONVERSION = YES;
CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS = YES;
CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR;
CLANG_WARN_EMPTY_BODY = YES;
CLANG_WARN_ENUM_CONVERSION = YES;
CLANG_WARN_INFINITE_RECURSION = YES;
CLANG_WARN_INT_CONVERSION = YES;
CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES;
CLANG_WARN_OBJC_IMPLICIT_RETAIN_SELF = YES;
CLANG_WARN_OBJC_LITERAL_CONVERSION = YES;
CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR;
CLANG_WARN_RANGE_LOOP_ANALYSIS = YES;
CLANG_WARN_STRICT_PROTOTYPES = YES;
CLANG_WARN_SUSPICIOUS_MOVE = YES;
CLANG_WARN_UNREACHABLE_CODE = YES;
CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
CODE_SIGN_IDENTITY = "";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
COPY_PHASE_STRIP = YES;
DEVELOPMENT_TEAM = 5HK2Q4J4X4;
ENABLE_NS_ASSERTIONS = NO;
ENABLE_STRICT_OBJC_MSGSEND = YES;
"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = i386;
GCC_C_LANGUAGE_STANDARD = gnu99;
GCC_NO_COMMON_BLOCKS = YES;
GCC_PREPROCESSOR_DEFINITIONS = (
"$(inherited)",
_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION,
);
GCC_WARN_64_TO_32_BIT_CONVERSION = YES;
GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR;
GCC_WARN_UNDECLARED_SELECTOR = YES;
GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
INFOPLIST_OTHER_PREPROCESSOR_FLAGS = "-traditional";
INFOPLIST_PREPROCESS = YES;
IPHONEOS_DEPLOYMENT_TARGET = 13.4;
LIBRARY_SEARCH_PATHS = (
"$(SDKROOT)/usr/lib/swift",
"\"$(TOOLCHAIN_DIR)/usr/lib/swift/$(PLATFORM_NAME)\"",
"\"$(inherited)\"",
);
MTL_ENABLE_DEBUG_INFO = NO;
OTHER_CFLAGS = "$(inherited) ";
OTHER_CPLUSPLUSFLAGS = "$(inherited) ";
OTHER_LDFLAGS = "$(inherited)";
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
SDKROOT = iphoneos;
SWIFT_COMPILATION_MODE = wholemodule;
SWIFT_VERSION = 5.0;
USE_HERMES = true;
VALIDATE_PRODUCT = YES;
};
name = Prerelease;
};
BB2FFDA22CAD600D00AB17D8 /* Prerelease */ = {
isa = XCBuildConfiguration;
baseConfigurationReference = F77638C1F4BC132FB97FEEAF /* Pods-ledgerlivemobile.release.xcconfig */;
buildSettings = {
ASSETCATALOG_COMPILER_APPICON_NAME = PrereleaseAppIcon;
CLANG_ENABLE_MODULES = YES;
CODE_SIGN_ENTITLEMENTS = ledgerlivemobile/ledgerlivemobile.entitlements;
CODE_SIGN_IDENTITY = "Apple Development";
"CODE_SIGN_IDENTITY[sdk=iphoneos*]" = "iPhone Developer";
CODE_SIGN_STYLE = Automatic;
CURRENT_PROJECT_VERSION = 381;
DEVELOPMENT_TEAM = X6LFS5BQKN;
ENABLE_BITCODE = NO;
FRAMEWORK_SEARCH_PATHS = (
"$(PROJECT_DIR)",
"$(PROJECT_DIR)/ledgerlivemobile",
"$(SRCROOT)",
"$(inherited)",
);
HEADER_SEARCH_PATHS = "$(inherited)";
INFOPLIST_FILE = ledgerlivemobile/Info.plist;
IPHONEOS_DEPLOYMENT_TARGET = 13.4;
LD_RUNPATH_SEARCH_PATHS = (
"$(inherited)",
/usr/lib/swift,
"@executable_path/Frameworks",
);
LIBRARY_SEARCH_PATHS = (
"$(SDKROOT)/usr/lib/swift",
"$(inherited)",
);
OTHER_CFLAGS = "$(inherited)";
OTHER_LDFLAGS = (
"$(inherited)",
"-ObjC",
"-lc++",
);
OTHER_SWIFT_FLAGS = "$(inherited) -D EXPO_CONFIGURATION_RELEASE";
PRODUCT_BUNDLE_IDENTIFIER = com.ledger.live.prerelease;
PRODUCT_NAME = ledgerlivemobile;
PROVISIONING_PROFILE = "";
PROVISIONING_PROFILE_SPECIFIER = "";
SWIFT_OBJC_BRIDGING_HEADER = "ledgerlivemobile-Bridging-Header.h";
SWIFT_VERSION = 5.0;
VALID_ARCHS = "$(ARCHS_STANDARD)";
VERSIONING_SYSTEM = "apple-generic";
};
name = Prerelease;
};
/* End XCBuildConfiguration section */

/* Begin XCConfigurationList section */
Expand All @@ -1141,6 +1258,7 @@
13B07F941A680F5B00A75B9A /* Debug */,
13B07F951A680F5B00A75B9A /* Release */,
BB0B80022CAAB47600AF2B0C /* Nightly */,
BB2FFDA22CAD600D00AB17D8 /* Prerelease */,
76138D0A243CBC8E00264435 /* Staging */,
);
defaultConfigurationIsVisible = 0;
Expand All @@ -1152,6 +1270,7 @@
83CBBA201A601CBA00E9B192 /* Debug */,
83CBBA211A601CBA00E9B192 /* Release */,
BB0B80012CAAB47600AF2B0C /* Nightly */,
BB2FFDA12CAD600D00AB17D8 /* Prerelease */,
76138D09243CBC8E00264435 /* Staging */,
);
defaultConfigurationIsVisible = 0;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,116 @@
{
"images" : [
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"scale" : "2x",
"size" : "20x20"
},
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"scale" : "3x",
"size" : "20x20"
},
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"scale" : "2x",
"size" : "29x29"
},
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"scale" : "3x",
"size" : "29x29"
},
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"scale" : "2x",
"size" : "38x38"
},
{
"filename" : "Icon-App-57x57@2x 1.png",
"idiom" : "universal",
"platform" : "ios",
"scale" : "3x",
"size" : "38x38"
},
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"scale" : "2x",
"size" : "40x40"
},
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"scale" : "3x",
"size" : "40x40"
},
{
"filename" : "Icon-App-60x60@2x 1.png",
"idiom" : "universal",
"platform" : "ios",
"scale" : "2x",
"size" : "60x60"
},
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"scale" : "3x",
"size" : "60x60"
},
{
"idiom" : "universal",
"platform" : "ios",
"scale" : "2x",
"size" : "64x64"
},
{
"idiom" : "universal",
"platform" : "ios",
"scale" : "3x",
"size" : "64x64"
},
{
"idiom" : "universal",
"platform" : "ios",
"scale" : "2x",
"size" : "68x68"
},
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"scale" : "2x",
"size" : "76x76"
},
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"scale" : "2x",
"size" : "83.5x83.5"
},
{
"filename" : "[email protected]",
"idiom" : "universal",
"platform" : "ios",
"size" : "1024x1024"
}
],
"info" : {
"author" : "xcode",
"version" : 1
}
}
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion apps/ledger-live-mobile/mobile-env.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ In other cases, these env files will be used:
| target | iOS | Android |
|--|--|--|
|release|com.ledger.live|com.ledger.live|
|prerelease|com.ledger.live|com.ledger.live|
|prerelease|com.ledger.live.prerelease|com.ledger.live|
|nightly|com.ledger.live.nightly|com.ledger.live|
|staging|com.ledger.live.dev|com.ledger.live.dev|
# Sentry projects
Expand Down
Loading