-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push prerelease builds to new prerelease app #7986
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
378deaf
build: create new app for prerelease and direct prerelease builds andβ¦
angusbayley ee2be70
build: new icon set for prerelease app
angusbayley 212b861
build: remove unnecessary array syntax
angusbayley 9081581
build: use .env for app configuration
angusbayley 48fd2f5
fix: update that autogenerated mobile-env.md file
angusbayley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
ENVFILE=.env.ios.prerelease | ||
APP_IDENTIFIER="com.ledger.live" | ||
MY_APP_BUNDLE_ID="com.ledger.live" | ||
APP_NAME="Ledger Live" | ||
APP_IDENTIFIER="com.ledger.live.prerelease" | ||
MY_APP_BUNDLE_ID="com.ledger.live.prerelease" | ||
APP_NAME="LL PRERELEASE" | ||
APP_CONFIGURATION="Prerelease" | ||
SENTRY_ENVIRONMENT=prerelease | ||
SENTRY_PROJECT=llm-ios-prerelease |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -142,6 +142,18 @@ platform :ios do | |
keychain_password: ENV["CI_KEYCHAIN_PASSWORD"], | ||
git_basic_authorization: Base64.strict_encode64("#{ENV["GIT_REPO_USER"]}:#{ENV["GH_TOKEN"]}"), | ||
) | ||
match( | ||
type: "appstore", | ||
app_identifier: "com.ledger.live.prerelease", | ||
force: true, | ||
generate_apple_certs: true, | ||
git_url: ENV["GIT_REPO_URL"], | ||
username: ENV["APPLE_ID"], | ||
team_id: ENV["DEVELOPER_TEAM_ID"], | ||
keychain_name: ENV["CI_KEYCHAIN_NAME"], | ||
keychain_password: ENV["CI_KEYCHAIN_PASSWORD"], | ||
git_basic_authorization: Base64.strict_encode64("#{ENV["GIT_REPO_USER"]}:#{ENV["GH_TOKEN"]}"), | ||
) | ||
end | ||
|
||
desc "buid for deployment (app-store or ad-hoc)" | ||
|
@@ -163,10 +175,9 @@ platform :ios do | |
|
||
build_number = latest_testflight_build_number( | ||
version: trim_version_number(package["version"]), | ||
# we are moving to using ENV["APP_IDENTIFIER"] but staging + prerelease still override their own | ||
# app identifier to publish to com.ledger.live . This will be removed once we are are fully publishing | ||
# to separate apps | ||
app_identifier: options[:nightly] ? ENV["APP_IDENTIFIER"] : "com.ledger.live" | ||
# we are moving to using ENV["APP_IDENTIFIER"] but staging still overrides its own app identifier to | ||
# publish to com.ledger.live . This will be removed once we are are fully publishing to separate apps | ||
app_identifier: !options[:adhoc] ? ENV["APP_IDENTIFIER"] : "com.ledger.live" | ||
) | ||
|
||
increment_build_number({ | ||
|
@@ -258,9 +269,7 @@ platform :ios do | |
gym( | ||
scheme: PROJECT_NAME, | ||
workspace: XCODE_WORKSPACE, | ||
# This should come from env files - as we move each release type to its own app we will | ||
#Β move them away from "Release" and to their own .env-file defined configuration | ||
configuration: options[:nightly] ? ENV["APP_CONFIGURATION"] : "Release", | ||
configuration: ENV["APP_CONFIGURATION"], | ||
silent: true, | ||
xcargs: `#{settings_to_override} -UseNewBuildSystem=YES`, | ||
output_directory: OUTPUT_DIRECTORY, | ||
|
@@ -312,6 +321,19 @@ platform :ios do | |
|
||
UI.important("Another build is already in external beta review. Skipping external beta review submission") | ||
end | ||
elsif (options[:prerelease]) | ||
pilot( | ||
skip_submission: false, | ||
app_identifier: ENV["APP_IDENTIFIER"], | ||
skip_waiting_for_build_processing: true, | ||
ipa: IPA_DIRECTORY, | ||
changelog: "Prerelease Build v#{package['version']} (#{build_number})", | ||
beta_app_review_info: { | ||
contact_email: "[email protected]", | ||
contact_first_name: "Ledger Live", | ||
notes: "test prerelease builds" | ||
} | ||
) | ||
else | ||
pilot( | ||
skip_submission: true, | ||
|
@@ -338,16 +360,16 @@ platform :ios do | |
lane :ci_testflight do |options| | ||
setup_ios_ci | ||
build(ci: true) | ||
upload(ci: true) | ||
upload( | ||
prerelease: true, | ||
ci: true | ||
) | ||
end | ||
|
||
desc "ci: create nightly version" | ||
lane :ci_nightly do |options| | ||
setup_ios_ci | ||
build( | ||
nightly: true, | ||
ci: true | ||
) | ||
build(ci: true) | ||
upload( | ||
nightly: true, | ||
ci: true | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
116 changes: 116 additions & 0 deletions
116
...ve-mobile/ios/ledgerlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,116 @@ | ||
{ | ||
"images" : [ | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "2x", | ||
"size" : "20x20" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "3x", | ||
"size" : "20x20" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "2x", | ||
"size" : "29x29" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "3x", | ||
"size" : "29x29" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "2x", | ||
"size" : "38x38" | ||
}, | ||
{ | ||
"filename" : "Icon-App-57x57@2x 1.png", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "3x", | ||
"size" : "38x38" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "2x", | ||
"size" : "40x40" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "3x", | ||
"size" : "40x40" | ||
}, | ||
{ | ||
"filename" : "Icon-App-60x60@2x 1.png", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "2x", | ||
"size" : "60x60" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "3x", | ||
"size" : "60x60" | ||
}, | ||
{ | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "2x", | ||
"size" : "64x64" | ||
}, | ||
{ | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "3x", | ||
"size" : "64x64" | ||
}, | ||
{ | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "2x", | ||
"size" : "68x68" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "2x", | ||
"size" : "76x76" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"scale" : "2x", | ||
"size" : "83.5x83.5" | ||
}, | ||
{ | ||
"filename" : "[email protected]", | ||
"idiom" : "universal", | ||
"platform" : "ios", | ||
"size" : "1024x1024" | ||
} | ||
], | ||
"info" : { | ||
"author" : "xcode", | ||
"version" : 1 | ||
} | ||
} |
Binary file added
BIN
+1008 Bytes
...erlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.53 KB
...erlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.47 KB
...erlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.38 KB
...erlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.16 KB
...erlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.06 KB
...erlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.45 KB
...livemobile/Images.xcassets/PrereleaseAppIcon.appiconset/Icon-App-57x57@2x 1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+3.06 KB
...livemobile/Images.xcassets/PrereleaseAppIcon.appiconset/Icon-App-60x60@2x 1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.85 KB
...erlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+1.92 KB
...erlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.27 KB
...erlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.72 KB
...vemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+12.4 KB
...gerlivemobile/Images.xcassets/PrereleaseAppIcon.appiconset/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
configuration is correctly set in
.env
files for this one π₯³