-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support/pin pr workflow deps #8117
base: develop
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ 5 Skipped Deployments
|
@@ -19,13 +19,18 @@ jobs: | |||
build-desktop-app: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest, windows-latest, macos-latest] | |||
name: "Build Ledger Live Desktop" | |||
runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a result of the workflows in build-desktop-external-reusable.yml
and build-desktop-reusable.yml
drifting out of sync, as they are partial copy-pasted duplicates of each other. Would love to remove as much duplication as possible (ideally delete the unused workflow)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. We don't want to use our internal runners for external contributions. So I think that ubuntu-latest is used for Github runner. Can you double check, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - fixed
@@ -19,13 +19,18 @@ jobs: | |||
build-desktop-app: | |||
strategy: | |||
matrix: | |||
os: [ubuntu-latest, windows-latest, macos-latest] | |||
name: "Build Ledger Live Desktop" | |||
runs-on: ${{ matrix.os }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. We don't want to use our internal runners for external contributions. So I think that ubuntu-latest is used for Github runner. Can you double check, please?
π Description
Pins dependencies for all PR workflows. That means all workflows triggered
on: pull_request
oron: push
.β Context
Ticket: https://ledgerhq.atlassian.net/browse/LIVE-14091
π§ Checklist for the PR Reviewers