-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support/pin pr workflow deps #8117
Open
angusbayley
wants to merge
5
commits into
develop
Choose a base branch
from
support/pin-PR-workflow-deps
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
adf523a
build: pin dependencies for build-and-test-PR workflows
angusbayley 00fc0cb
build: build determine-affected
angusbayley 2436867
build: pin versions for external build and test on PR
angusbayley 44e5df9
build: pin all remaining "-latest" unpinned OS images
angusbayley ebe6974
build: use pinned GH ubuntu for external workflows, not internal runner
angusbayley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,6 +9,6 @@ permissions: | |
|
||
jobs: | ||
assign-author: | ||
runs-on: ubuntu-latest | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: toshimaru/[email protected] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18925,7 +18925,7 @@ var package_default = { | |
"doc:ljs": 'pnpm turbo doc --no-daemon --filter="./libs/ledgerjs/**"', | ||
"watch:ljs": 'pnpm turbo watch --no-daemon --filter="./libs/ledgerjs/**"', | ||
"watch:common": "pnpm turbo watch --no-daemon --filter=./libs/ledger-live-common", | ||
"dev:cli": "pnpm turbo watch --no-daemon --filter=@ledgerhq/live-cli", | ||
"dev:cli": "pnpm turbo watch --filter=@ledgerhq/live-cli", | ||
"dev:lld": "pnpm turbo start --no-daemon --filter=ledger-live-desktop", | ||
"dev:lld:debug": "DEV_TOOLS=1 LEDGER_INTERNAL_ARGS=--inspect ELECTRON_ARGS=--remote-debugging-port=8315 pnpm turbo start --no-daemon --filter=ledger-live-desktop", | ||
"dev:llm": "pnpm turbo start --no-daemon --filter=live-mobile", | ||
|
@@ -19073,14 +19073,15 @@ var package_default = { | |
"@ledgerhq/devices": "workspace:*", | ||
tslib: "2.6.2", | ||
"@hashgraph/sdk>@grpc/grpc-js": "1.6.7", | ||
"@hashgraph/sdk>@hashgraph/cryptography": "1.1.2" | ||
"@hashgraph/sdk>@hashgraph/cryptography": "1.1.2", | ||
"@ethersproject/providers>ws": "7.5.10" | ||
}, | ||
patchedDependencies: { | ||
"[email protected]": "patches/[email protected]", | ||
"[email protected]": "patches/[email protected]", | ||
"[email protected]": "patches/[email protected]", | ||
"[email protected]": "patches/[email protected]", | ||
"detox@20.23.0": "patches/detox@20.23.0.patch", | ||
"detox@20.26.2": "patches/detox@20.26.2.patch", | ||
"[email protected]": "patches/[email protected]", | ||
"[email protected]": "patches/[email protected]", | ||
"@hashgraph/[email protected]": "patches/@[email protected]", | ||
|
@@ -19111,6 +19112,7 @@ async function main() { | |
const pkg = core.getInput("package") || ""; | ||
const command = core.getInput("command"); | ||
const turboVersion = package_default.devDependencies.turbo; | ||
const packageManager = package_default.packageManager; | ||
try { | ||
const turboOutput = (0, import_child_process.execSync)( | ||
`npx turbo@${turboVersion} run ${command} --filter=...[${ref}] --dry=json`, | ||
|
@@ -19119,7 +19121,7 @@ async function main() { | |
maxBuffer: 2048 * 1024 | ||
} | ||
); | ||
const pnpmOutput = (0, import_child_process.execSync)(`npx pnpm list -r --depth=0 --json`, { | ||
const pnpmOutput = (0, import_child_process.execSync)(`npx ${packageManager} list -r --depth=0 --json`, { | ||
encoding: "utf-8", | ||
maxBuffer: 2048 * 1024 | ||
}); | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a result of the workflows in
build-desktop-external-reusable.yml
andbuild-desktop-reusable.yml
drifting out of sync, as they are partial copy-pasted duplicates of each other. Would love to remove as much duplication as possible (ideally delete the unused workflow)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure. We don't want to use our internal runners for external contributions. So I think that ubuntu-latest is used for Github runner. Can you double check, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point - fixed