Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lld): 🚩 add the feature_lld_NanoS_upsell_banners flag #9199

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

feat(lld): 🚩 add the feature_lld_NanoS_upsell_banners flag #9199

wants to merge 5 commits into from
+289 −112

Conversation

thesan
Copy link
Contributor

@thesan thesan commented Feb 12, 2025 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Add and test the feature_lld_NanoS_upsell_banners feature flag.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Feb 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 3:08pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 3:08pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 3:08pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 3:08pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Feb 12, 2025
@thesan thesan force-pushed the feat/lld-lns-banners-components branch from c0a397e to 30457f4 Compare February 13, 2025 14:17
@thesan thesan force-pushed the feat/lld-lns-upsell-ff branch from 3201271 to 782feb7 Compare February 13, 2025 14:30
@thesan thesan force-pushed the feat/lld-lns-banners-components branch from 30457f4 to 6e5633f Compare February 13, 2025 14:32
@thesan thesan force-pushed the feat/lld-lns-upsell-ff branch from 782feb7 to e2228e8 Compare February 13, 2025 14:34
@thesan thesan force-pushed the feat/lld-lns-banners-components branch 3 times, most recently from 2457e9d to fd035c8 Compare February 14, 2025 12:36
@thesan thesan force-pushed the feat/lld-lns-upsell-ff branch from e2228e8 to 053d765 Compare February 14, 2025 12:49
@thesan thesan force-pushed the feat/lld-lns-banners-components branch from fd035c8 to 49dfe24 Compare February 17, 2025 15:28
@thesan thesan force-pushed the feat/lld-lns-upsell-ff branch from 053d765 to 9ef4b12 Compare February 17, 2025 15:30
Base automatically changed from feat/lld-lns-banners-components to develop February 17, 2025 16:54
@thesan thesan force-pushed the feat/lld-lns-upsell-ff branch from 9ef4b12 to b544603 Compare February 18, 2025 12:27
@thesan thesan marked this pull request as ready for review February 18, 2025 12:30
@thesan thesan requested a review from a team as a code owner February 18, 2025 12:30
@thesan thesan force-pushed the feat/lld-lns-upsell-ff branch from b544603 to 62a3f04 Compare February 18, 2025 13:53
@thesan thesan force-pushed the feat/lld-lns-upsell-ff branch from 62a3f04 to 9b9f11d Compare February 18, 2025 15:08
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
8 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@thesan thesan

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thesan @mcayuelas-ledger