Added translations for the SSO Support #152
Conversation
…registration_application_pending"
|
@dessalines @SleeplessOne1917 |
| @@ -429,6 +430,7 @@ | |||
| "invalid_username": "Invalid username.", | |||
| "admin_already_created": "Sorry, there's already an admin.", | |||
| "user_already_exists": "User already exists.", | |||
| "username_already_exists": "Username already exists.", | |||
There was a problem hiding this comment.
Is there a meaningful difference between this and user_already_exists?
There was a problem hiding this comment.
Username is just more clear given that there's a Username input field that the user is submitting. User could include email too.
translations/en.json
Outdated
| "oauth_client_secret": "Client Secret", | ||
| "oauth_scopes": "OAuth Scopes", | ||
| "oauth_auto_verify_email": "Auto-Verify Email", | ||
| "oauth_account_linking_enabled": "Account Linking Enabled", |
There was a problem hiding this comment.
"Enable Account Linking" reads a bit more clearly imo.
| "no_oauth_providers_blurb": "No providers", | ||
| "delete_oauth_provider_are_you_sure": "Are you sure you want to delete this provider?", | ||
| "deleting_oauth_provider": "Deleting provider...", | ||
| "oauth_display_name": "Display Name", |
There was a problem hiding this comment.
We actually already have a "display_name" entry with the same value. Unless it's possible that this will differ from that one in other languages, we should use the existing one.
There was a problem hiding this comment.
We made them separate for this exact purpose.
translations/en.json
Outdated
| "oauth_scopes": "OAuth Scopes", | ||
| "oauth_auto_verify_email": "Auto-Verify Email", | ||
| "oauth_account_linking_enabled": "Account Linking Enabled", | ||
| "oauth_enabled": "Enabled", |
There was a problem hiding this comment.
If I understand correctly, this controls whether users can actually use a given provider? In that case, "Enable Provider" might make things less vague.
Also, should OAuth providers that aren't enabled be shown to clients on the login screen?
There was a problem hiding this comment.
Only enabled providers should be shown to clients. It's already the case.
| "couldnt_create_oauth_provider": "Couldn't create OAuth provider.", | ||
| "or": "Or", | ||
| "available_oauth_providers": "Login with", | ||
| "oauth_login_with_provider": "Login with SSO Provider", |
There was a problem hiding this comment.
We might need to remove oauth_login_with_provider depending on this potential change.
There was a problem hiding this comment.
I think keeping oauth_login_with_providers is good to keep. If there's anything we need to remove, it's available_oauth_providers.
There was a problem hiding this comment.
Oh this was part of the modal. Removed it.
|
|
@SleeplessOne1917 the translations are ready if there are no more changes on the UI side. |
Added the translations for the SSO Support