Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translations for the SSO Support #152

Merged
merged 4 commits into from
Oct 7, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions translations/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
"send_message": "Send Message",
"message": "Message",
"edit": "Edit",
"add": "Add",
"reply": "Reply",
"more": "More",
"cancel": "Cancel",
Expand Down Expand Up @@ -429,6 +430,7 @@
"invalid_username": "Invalid username.",
"admin_already_created": "Sorry, there's already an admin.",
"user_already_exists": "User already exists.",
"username_already_exists": "Username already exists.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a meaningful difference between this and user_already_exists?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Username is just more clear given that there's a Username input field that the user is submitting. User could include email too.

"email_already_exists": "Email already exists.",
"couldnt_update_user": "Couldn't update user.",
"system_err_login": "System error. Try logging out and back in.",
Expand Down Expand Up @@ -596,6 +598,7 @@
"remote_follow": "Remote Follow",
"remote_follow_modal_title": "Subscribe from Remote Instance",
"blur_nsfw": "Blur NSFW content",
"auto_expand": "Auto expand media",
"remote_follow_invalid_instance": "{{instance}} is not a vaild domain.",
"remote_follow_local_instance": "Cannot fetch local instance for remote follow",
"import_export_section_title": "Import/Export Settings",
Expand All @@ -611,6 +614,36 @@
"import_success": "Settings successfully imported!",
"confirmation_required": "Confirmation Required",
"submit": "Submit",
"authentication": "Authentication",
"oauth_config": "OAuth Configuration",
"oauth_providers": "Providers",
"add_oauth_provider": "Add provider",
"oauth_provider_presets": "Preset Providers",
"no_oauth_providers_blurb": "No providers",
"delete_oauth_provider_are_you_sure": "Are you sure you want to delete this provider?",
"deleting_oauth_provider": "Deleting provider...",
"oauth_display_name": "Display Name",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually already have a "display_name" entry with the same value. Unless it's possible that this will differ from that one in other languages, we should use the existing one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We made them separate for this exact purpose.

"oauth_issuer": "Issuer",
"oauth_authorization_endpoint": "Authorization Endpoint",
"oauth_token_endpoint": "Token Endpoint",
"oauth_userinfo_endpoint": "User Info Endpoint",
"oauth_id_claim": "ID Claim",
"oauth_client_id": "Client ID",
"oauth_client_secret": "Client Secret",
"cannot_view_secret_after_saving": "Cannot view secret after saving",
"oauth_scopes": "OAuth Scopes",
"oauth_auto_verify_email": "Auto-Verify Email",
"oauth_account_linking_enabled": "Enable Account Linking",
"oauth_enabled": "Enable Provider",
"couldnt_edit_oauth_provider": "Couldn't edit OAuth provider.",
"couldnt_delete_oauth_provider": "Couldn't delete OAuth provider.",
"couldnt_create_oauth_provider": "Couldn't create OAuth provider.",
"or": "Or",
"oauth_login_with_provider": "Login with SSO Provider",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to remove oauth_login_with_provider depending on this potential change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think keeping oauth_login_with_providers is good to keep. If there's anything we need to remove, it's available_oauth_providers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this was part of the modal. Removed it.

"oauth_authorization_invalid": "Login Authorization Failed.",
"oauth_login_failed": "Login Failed.",
"oauth_registration_closed": "Registration closed.",
"oauth_registration": "Allow Registration via OAuth",
"community_locked_message": "<1>Community locked:</1> only moderators can create posts. You can still comment on posts.",
"community_locked": "Community locked",
"community_visibility": "Visibility",
Expand Down