Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract MiqFileStorage and MiqFtpLib #454

Closed
wants to merge 2 commits into from
Closed

Extract MiqFileStorage and MiqFtpLib #454

wants to merge 2 commits into from

Commits on Dec 17, 2019

  1. Extract object_storage_and_ftp_lib

    @NickLaMuro
    NickLaMuro committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    8bd0e89 View commit details
    Browse the repository at this point in the history

  2. [gemspec] Remove unneeded dependencies 

    - `aws-sdk-s3`:     Only used in `miq_s3_storage.rb`
- `fog-openstack`:  Only used in `miq_swift_storage.rb`
- `mime_types`:     Added for `miq_swift_storage.rb`
- `ftpd`:           Added for `miq_ftp_lib.rb` testing

Relevant PR Links:

- https://github.com/ManageIQ/manageiq-gems-pending/pull/355/files#diff-2da54afac1b7bdf3864a10f2304fcb7a
- https://github.com/ManageIQ/manageiq-gems-pending/pull/371/files#diff-2da54afac1b7bdf3864a10f2304fcb7a
- https://github.com/ManageIQ/manageiq-gems-pending/pull/360/files#diff-2da54afac1b7bdf3864a10f2304fcb7a
    @NickLaMuro
    NickLaMuro committed Dec 17, 2019
    Configuration menu
    Copy the full SHA
    b3ca377 View commit details
    Browse the repository at this point in the history