Extract MiqFileStorage and MiqFtpLib #454
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Butts... noticed I forgot a file... back in a bit... |
NickLaMuro
force-pushed
the
extract_file_storage_and_ftp_lib
branch
from
ec2a2d6
to
98a398d
Compare
|
This is the other half of ManageIQ/manageiq#19547 |
3 tasks
|
This pull request is not mergeable. Please rebase and repush. |
NickLaMuro
force-pushed
the
extract_file_storage_and_ftp_lib
branch
from
98a398d
to
b3ca377
Compare
- `aws-sdk-s3`: Only used in `miq_s3_storage.rb` - `fog-openstack`: Only used in `miq_swift_storage.rb` - `mime_types`: Added for `miq_swift_storage.rb` - `ftpd`: Added for `miq_ftp_lib.rb` testing Relevant PR Links: - https://github.com/ManageIQ/manageiq-gems-pending/pull/355/files#diff-2da54afac1b7bdf3864a10f2304fcb7a - https://github.com/ManageIQ/manageiq-gems-pending/pull/371/files#diff-2da54afac1b7bdf3864a10f2304fcb7a - https://github.com/ManageIQ/manageiq-gems-pending/pull/360/files#diff-2da54afac1b7bdf3864a10f2304fcb7a
|
Checked commits NickLaMuro/manageiq-gems-pending@8bd0e89~...b3ca377 with ruby 2.5.5, rubocop 0.69.0, haml-lint 0.20.0, and yamllint 1.10.0 |
NickLaMuro
added a commit
to NickLaMuro/manageiq-cross_repo-tests
that referenced
this pull request
Jan 21, 2020
This is a modified matrix that tests the changes in the following PRs: - ManageIQ/manageiq#19547 - ManageIQ/manageiq-gems-pending#454 but replaces ManageIQ/manageiq#19547 with the following branch: https://github.com/NickLaMuro/manageiq/tree/rebase_testing Which does a few extra steps to attempt to graft commits prior to rebasing. Unsure of the `git` results, but before open a separate PR, this should test to see if specs still pass.
NickLaMuro
added a commit
to NickLaMuro/manageiq-cross_repo-tests
that referenced
this pull request
Jan 21, 2020
This is a modified matrix that tests the changes in the following PRs: - ManageIQ/manageiq#19547 - ManageIQ/manageiq-gems-pending#454 but replaces ManageIQ/manageiq#19547 with the following branch: https://github.com/NickLaMuro/manageiq/tree/rebase_testing Which does a few extra steps to attempt to graft commits prior to rebasing. Unsure of the `git` results, but before open a separate PR, this should test to see if specs still pass.
This was referenced Jan 21, 2020
|
This pull request has been automatically closed because it has not been updated for at least 3 months. Feel free to reopen this pull request if these changes are still valid. Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other half of ManageIQ/manageiq#19547
Also removes some unneeded gem dependencies as a result! 🎉
Note:
I did rename this branch to
extract_file_storage_and_ftp_lib(instead of*_object_storage), since that is the top level module, so "more correcter".Links