Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove miq-kernel.rb / require_relative #478

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Remove miq-kernel.rb / require_relative #478

merged 2 commits into from
Jun 15, 2020

Conversation

djberg96
Copy link
Contributor

@djberg96 djberg96 commented Jun 15, 2020

The original issue mentioned in http://bugs.ruby-lang.org/issues/4487 appears to be fixed:

>cat eval_me1.rb 
eval(File.read('eval_me2.rb'), binding, File.expand_path('./eval_me2.rb'))

>cat eval_me2.rb 
require_relative 'eval_me1.rb'

>ruby eval_me2.rb # nothing
>ruby eval_me1.rb # nothing

I also tried loading them in irb:

irb(main):001:0> load "eval_me1.rb"
=> true
irb(main):002:0> load "eval_me2.rb"
=> true

I tried with both 2.5.7 and 2.6.5.

Part of the cleanup from #231

@miq-bot
Copy link
Member

miq-bot commented Jun 15, 2020

Checked commits https://github.com/djberg96/manageiq-gems-pending/compare/0e2b03cda815b9ac7d4b8a1885af1e74f0a78a6a~...8a7169817905e4c92b5ee1d910a1cad47e7350d6 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. 👍

@Fryguy
Copy link
Member

Fryguy commented Jun 15, 2020

I also verified locally in a clean irb both eval and require_relative directly and it all seems to work now.

@Fryguy Fryguy merged commit 3e92bac into ManageIQ:master Jun 15, 2020
@Fryguy Fryguy self-assigned this Jun 15, 2020
@Fryguy Fryguy mentioned this pull request Jun 15, 2020
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants