gems/pending/util general cleanup

[Fryguy]

Delete

Completed

• diag/miqping.rb - MiqWsPing Remove MiqWsPing as it's no longer used #226
• MiqDumpObj.rb Remove MiqDumpObj as it's no longer used #227
• MiqVmFsUtil.rb Remove MiqVmFsUtil as it's no longer used #228
• SyncDebug -> Remove SyncDebug from VimBroker vmware_web_service#55 & remove unused SyncDebug #471
• Core extensions:
  • miq-kernel#add_to_load_path -> delete Remove extension Kernel#add_to_load_path as it's not used #230
  • miq-kernel#require_relative -> delete Remove miq-kernel.rb / require_relative #478
• MiqSockUtil -> delete Remove MiqSockUtil #482
• miq-encode.rb
  • base24Decode -> delete remove unused MIQEncode.base24Decode method #472
  • base64* -> delete Remove MIQEncode#base64* as they are no longer used #229
• miq-logger -> delete Remove MIQlogger and log4r #295
• miq-metakit -> Remove miq-metakit.rb #506
• postgres_admin Extract PostgresAdmin into a separate gem #404 Remove PostgresAdmin #516
• runcmd (core - to delete / replace with AwesomeSpawn) - Remove MiqUtil.runcmd in favor of AwesomeSpawn #510
• vmdb-logger (Use manageiq-loggers instead - Remove in Remove VMDBLogger #529)

Dedicated gem/process/application

• miq-password -> became ManageIQ::Password gem Remove miq-password and use ManageIQ::Password instead #417 + Remove miq-password #424
• duplicate_blocker/* + duplicate_blocker.rb (perhaps it should fork the original instead and re-release?)
• MiqSshUtil -> became manageiq-ssh-util gem Remove MiqSshUtil.rb #470
  • Host fleecing (is that even a thing, since the code says "not esxi"?)
  • Automate can ssh exec a script on a host
  • Host verify ssh creds (for what purpose, though?)
• win32/wimparser Extract WimParser to a dedicated gem #514

Move

Completed

• miq_apache/* -> ManageIQ (for evmserver purposes) Move MiqApache to ManageIQ #235 + Move MiqApache from manageiq-gems-pending manageiq#15548
• miq-syntax-checker -> automation_engine / automation_models (MiqAeMethod) Move MiqSyntaxChecker to manageiq-automation_engine #237 + Move SyntaxChecker from manageiq-gems-pending manageiq-automation_engine#51 + Use SyntaxChecker from AutomationEngine manageiq#15550
• miq-unicode -> Remove miq-unicode.rb #509 + Integrate miq-unicode.rb into smartstate manageiq-smartstate#149
• miq_tempfile -> Remove miq_tempfile.rb #469 + Move miq_tempfile here manageiq-smartstate#124
• system/evm_watchdog.rb -> manageiq-appliance Move EvmWatchdog to manageiq-appliance #236 + Move EvmWatchdog here from manageiq-gems-pending manageiq-appliance#128

Dependencies

Completed

• log4r -> delete Remove MIQlogger and log4r #295

Keep in core ^[ref]

• mount/* Move MiqFileStorage into core and provider specific gems #403
• xml/* (core - to delete)
• win32/* (delete or breakdown further - e.g. wimparser to gem)
  • MiqWinrm
• miq-encode.rb
  • encode/decode
• miq-exception.rb
• miq-hash_struct.rb
• miq-ipmi (core - to delete)
• miq-process
• miq-system
• miq-logger-processor
• require_with_logging

core extensions

Completed

• move to more_core_extensions
  • miq-benchmark Extract Benchmark.realtime_store/block from manageiq-gems-pending more_core_extensions#65 + [WIP] Extract Benchmark.realtime_store/block to more_core_extensions #419 + Remove miq-benchmark #495
  • miq-deep#deep_clone/deep_delete Add deep_clone and deep_delete more_core_extensions#91 + Remove miq-deep.rb and specs #484
  • miq-hash Extract Hash sorting from manageiq-gems-pending more_core_extensions#46 + Extract hash sorting to more_core_extensions #242 + Remove miq-hash #493
  • miq-module Move cache_with_timeout extension from ManageIQ more_core_extensions#51 + Remove cache_with_timeout to move to more_core_extensions #251
  • miq-object#deep_send Add Object#deep_send more_core_extensions#94 + Remove miq-object #494
  • miq-range Extract Range#step_value from manageiq-gems-pending more_core_extensions#47 + Extract Range extension to more_core_extensions #246
  • miq-symbol Extract Symbol#to_i from manageiq-gems-pending more_core_extensions#49 + Extract Symbol#to_i to more_core_extensions #248
  • miq-uuid Replace miq-uuid with uuidtools manageiq-smartstate#130 + Extend the Digest::UUID module with the clean method more_core_extensions#81 + Remove miq-uuid.rb and specs #487
  • to_i_with_method - Add String#to_i_with_method and friends more_core_extensions#95 + Remove miq-to_i_with_method #496
  • miq-yaml (monkeypatch) - Drop legacy yml load of Hash subclasses with ivars #342
  • miq-stats (extension to Math module) Extract MiqStats from manageiq-gems-pending more_core_extensions#50 + Extract MiqStats in favor of Math extension in more_core_extensions #421
• other
  • to_miq_a (can we remove this or switch to Array.wrap) Deprecate #to_miq_a #483 + remove to_miq_a #489
  • miq-file (delete the win32 stuff, see what's left) Move miq-file extension to manageiq-smartstate #284

cc @chessbyte

[Fryguy]

@agrare SyncDebug here is slated for the vmware_web_service. Do you think it can be moved there, or is it even useful?

[agrare]

@Fryguy It hasn't been used in forever, I'm okay dropping it. I'll put in a PR to vmware_web_service to remove it.

[gildub]

@Fryguy, could you please clarify the following:

• By "Keep in core", do you mean manageiq/manageiq?
• Also more specifically about "miq-ipmi": by "core - to delete" you mean move to core and delete from gems-pending ?

Also I wonder if the core-extensions could be just named "util" ?

[Fryguy]

@gildub "Keep in core" just means that it will stay as a ManageIQ specific util, because there's no alternative. Some thing may need renames or cleanups, but conceptually it will just stay. This could mean just making a util directory in ManageIQ and moving it there, or creating a manageiq-util gem or something to that effect.

[Fryguy]

For, miq-ipmi in our research we were hoping to just delete the IPMI feature altogether. If it has to stay, it will "Keep in core", other we delete it.

[gildub]

@Fryguy, thanks. that's what I assumed, so good we moved the discovery bit in Util then.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 6 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions!

[NickLaMuro]

Created two issues related this one:

• Move MiqFileStorage into core and provider specific gems #403
• Extract PostgresAdmin into a separate gem #404

[Fryguy]

SyncDebug removal is done - ManageIQ/vmware_web_service#55 & #471 cc @chessbyte @agrare

[djberg96]

@Fryguy you said: "miq-kernel#require_relative (keep? still doesn't work in eval)". But, using the ticket (http://bugs.ruby-lang.org/issues/4487) as a guide, it seems to no longer raise an error:

>cat eval_me1.rb 
eval(File.read('eval_me2.rb'), binding, File.expand_path('./eval_me2.rb'))

>cat eval_me2.rb 
require_relative 'eval_me1.rb'

>ruby eval_me2.rb # nothing
>ruby eval_me1.rb # nothing

I also tried loading them in irb:

irb(main):001:0> load "eval_me1.rb"
=> true
irb(main):002:0> load "eval_me2.rb"
=> true

I tried with both 2.5.7 and 2.6.5.

[Fryguy]

The irb thing is also about calling require_relative and eval directly in irb, not via load, but that seems to work too. Nice!

[djberg96]

@Fryguy We can update MiqSshUtil on your checklist, which was split out into manageiq-ssh-util and removed from here.

[Fryguy]

I tweaked the OP to collapsed the completed sections into Details twistys.