Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fog-openstack to v1.0 #558

Merged
merged 1 commit into from
May 8, 2023
Merged

Update fog-openstack to v1.0 #558

merged 1 commit into from
May 8, 2023

Conversation

agrare
Copy link
Member

@agrare agrare commented May 2, 2023 •
edited
Loading

fog-openstack released v1.0 in Jan 2019 we should update to the latest version, this was also keeping us on an older version of fog-core

Co-depends:

@agrare agrare mentioned this pull request May 2, 2023
Merged
@miq-bot
Copy link
Member

miq-bot commented May 2, 2023

Checked commit agrare@68cbb8a with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
1 file checked, 1 offense detected

lib/gems/pending/util/object_storage/miq_swift_storage.rb

@agrare
Copy link
Member Author

agrare commented May 4, 2023

Actually do we still use MiqFileStorage for anything @Fryguy @jrafanie ? It seems like it was removed from evm_database_ops.rb in ManageIQ/manageiq#21384 and not used in the "new" implementation in appliance_console ManageIQ/manageiq-appliance_console#160

@agrare agrare closed this May 8, 2023
@agrare agrare reopened this May 8, 2023
@kbrock
Copy link
Member

kbrock commented May 8, 2023

we were able to successfully drop MiqFileStorage for database backups.
I thought there was a use for it in the ui.

may lead to more info:

@kbrock kbrock merged commit cd6ac11 into ManageIQ:master May 8, 2023
@agrare agrare deleted the update_fog_openstack_v1 branch May 8, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kbrock kbrock

Labels
dependencies providers/openstack
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agrare @miq-bot @kbrock