Update fog-openstack to v1.0

[agrare]

Co-depends: ManageIQ/manageiq-gems-pending#558

Follow-ups:

• Update VCRs for fog-openstack v1.0 manageiq-providers-ibm_cic#33
• TODO manageiq-providers-ibm_power_vc

[agrare]

@miq-bot cross-repo-tests ManageIQ/manageiq-gems-pending#525

[agrare]

Getting some VCR refresher errors that I'll need to work out the root cause of

[kbrock]

kicking

[agrare]

Only failing on the ironic/infra_manager specs because microstack doesn't have that service enabled

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request has been automatically closed because it has not been updated for at least 3 months.

Feel free to reopen this pull request if these changes are still valid.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the triage process documentation.

[agrare]

@miq-bot cross-repo-tests ManageIQ/manageiq-gems-pending#558

[agrare]

Cross-repo tests are green

[nasark]

Just wanted to add that fog v1.0 will allow us to support cinder V3 which is used in upstream Openstack Wallaby> releases

[agrare]

Hey @kbrock can you take a look?

[kbrock]

Are we concerned with:

• https://github.com/kbrock/manageiq-providers-openstack/blob/master/lib/tasks_private/openstack.rake#L41

Not sure if Fog::{Compute,Network,Identity} still works the same or if we need to add OpenStack in there as well.

[kbrock]

Also, could you update this comment with 2 references to the 2 classes?
Not sure if we want to verify/update that comment now that we are bumping fog by so much.

https://github.com/ManageIQ/manageiq-providers-openstack/blob/master/app/models/manageiq/providers/openstack/inventory/parser/cloud_manager.rb#L162

[agrare]

Not sure if Fog::{Compute,Network,Identity} still works the same or if we need to add OpenStack in there as well.

These do still work but can update for consistency

[agrare]

Also, could you update this comment with 2 references to the 2 classes?

Done

[miq-bot]

Some comments on commits agrare/manageiq-providers-openstack@d066587~...94b6b2b

spec/models/manageiq/providers/openstack/cloud_manager/refresh_spec_common.rb

• ⚠️ - 32 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 33 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 34 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 35 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 38 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 41 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 42 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 43 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 44 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 46 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 47 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 48 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 51 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.
• ⚠️ - 52 - Detected allow_any_instance_of. This RSpec method is highly discouraged, please only use when absolutely necessary.

[miq-bot]

Checked commits agrare/manageiq-providers-openstack@d066587~...94b6b2b with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
24 files checked, 3 offenses detected

spec/models/manageiq/providers/openstack/infra_manager/refresher_rhos_juno_spec.rb

• ❗ - Line 131, Col 109 - Layout/SpaceInsideBlockBraces - Space missing inside }.
• ❗ - Line 13, Col 89 - Layout/MultilineMethodCallBraceLayout - Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
• ❗ - Line 40, Col 111 - Layout/SpaceInsideBlockBraces - Space missing inside }.