Add deep_clone and deep_delete #91
Conversation
|
LGTM to me...can you also update the README? |
|
@Fryguy Done! |
| # h1[:a] # "hello world" | ||
| # h2[:a] # "hello" | ||
| # | ||
| def deep_clone |
There was a problem hiding this comment.
What do you think of #deep_clone living in https://github.com/ManageIQ/more_core_extensions/blob/master/lib/more_core_extensions/core_ext/shared/nested.rb instead?
There was a problem hiding this comment.
Would putting it there mean that users would have to explicitly include it to use it? I guess I'm not entirely clear on that particular module's approach as compared to the others.
There was a problem hiding this comment.
@bdunne ok, updated.
|
Checked commits https://github.com/djberg96/more_core_extensions/compare/7781fe4acf664e31993e2cb65fdc748b146011ee~...d4f8eaef0e8cbab360d350dad05686c5a735d37c with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint spec/core_ext/hash/deletes_spec.rb
|
This PR adds the
deep_cloneanddeep_deletemethods to theArrayandHashclasses.The implementations were pulled from miq-deep.rb in gems-pending.
Since the
deep_cloneimplementation was identical for both classes, I put them in a single file (enumerable.rb) and extended both classes from there. The idea is not only to avoid duplication, but other Enumerable classes could be easily added in the future as desired.Part of the cleanup effort at ManageIQ/manageiq-gems-pending#231