Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature index overlay bug #870

Closed
wants to merge 14 commits into from
Closed

Feature index overlay bug #870

wants to merge 14 commits into from

Conversation

prushforth
Copy link
Member

@prushforth prushforth commented Jul 5, 2023 •
edited
Loading

Supporting PR in mapml-extension

  • Make map the focus after following a link e.g. on this map
  • Make map the focus after reload() etc.
  • Verify that checking/unchecking layers works for feature index behaviour
  • Add test for post-geolocation activation, deactivation
  • Add test for post-link activation
  • Make output responsive (fit between lower controls without overlap)

@prushforth prushforth mentioned this pull request Jul 5, 2023
Merged
prushforth and others added 12 commits July 5, 2023 17:11
@prushforth
Remove commented code
ab95f20
Remove unused / uncovered code, add comments.
fb0e1bc 
Update _handleLink to focus map when finished handling, so that
the feature index shows up again (if enabled).
Ensure feature index and reticle displayed after reload
ec8b710 
Ensure feature index and reticle displayed before and after fullscreen
Upgrade playwright
8daed41 
Add tests for feature index and reticle display after fullscreen,
history navigation, link activation.
@prushforth
De-flake a test that got really bad post-upgrade of playwright
ab0cf4a
@prushforth
Remove layerchange layeradd layerremove overlayremove events from
a146970 
feature index handlers; the index and reticle display on map focus,
disappear when focus moves off map.  This seems a bit odd when adding
or removing layers, but it is simple, and reticle returns with focus.
@prushforth
Update GeolocationButton to focus the map after it locates the user.
a55c9e9 
Update geolocation tests to adapt to changes.
@prushforth
Add feature index tests for after reload, fullscreen, history nav,
3368adb 
geolocation activation,
@prushforth
Add test feature index presence post-geolocation activation,
176cc37 
deactivation, and link following actions
@prushforth
Formatting by prettier
ba49116
@prushforth
Split up slow test
183a6ee
@prushforth
Make feature index overlay responsive to map width
f9b1f72
@prushforth prushforth marked this pull request as ready for review July 8, 2023 19:44
@prushforth prushforth requested a review from Malvoz July 9, 2023 13:31
@prushforth
Copy link
Member Author

@Malvoz there are significant changes in this PR, would be great if you would have a look. Also: should this be a control?

@prushforth prushforth closed this Sep 22, 2023
@AliyanH
Copy link
Member

AliyanH commented Nov 8, 2023

moved to #873

@prushforth prushforth deleted the featureIndexOverlay-bug branch October 3, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Malvoz Malvoz Awaiting requested review from Malvoz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prushforth @AliyanH