Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature index overlay bug #870

Closed
wants to merge 14 commits into from
Closed

Feature index overlay bug #870

wants to merge 14 commits into from

Commits on Jun 30, 2023

  1. WIP on getting featureIndexOverlay to behave

    @prushforth
    prushforth committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    8d7de0f View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Add localized message to feature index output for 'No features found'

    @prushforth
    prushforth committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    a409e66 View commit details
    Browse the repository at this point in the history

  2. Remove commented code

    @prushforth
    prushforth committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    ab95f20 View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2023

  1. Remove unused / uncovered code, add comments. 

    Update _handleLink to focus map when finished handling, so that
the feature index shows up again (if enabled).
    prushfor authored and prushfor committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    fb0e1bc View commit details
    Browse the repository at this point in the history

  2. Ensure feature index and reticle displayed after reload 

    Ensure feature index and reticle displayed before and after fullscreen
    prushfor authored and prushfor committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    ec8b710 View commit details
    Browse the repository at this point in the history

  3. Upgrade playwright 

    Add tests for feature index and reticle display after fullscreen,
history navigation, link activation.
    prushfor authored and prushfor committed Jul 6, 2023
    Configuration menu
    Copy the full SHA
    8daed41 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. De-flake a test that got really bad post-upgrade of playwright

    @prushforth
    prushforth committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ab0cf4a View commit details
    Browse the repository at this point in the history

  2. Remove layerchange layeradd layerremove overlayremove events from 

    feature index handlers; the index and reticle display on map focus,
disappear when focus moves off map.  This seems a bit odd when adding
or removing layers, but it is simple, and reticle returns with focus.
    @prushforth
    prushforth committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a146970 View commit details
    Browse the repository at this point in the history

  3. Update GeolocationButton to focus the map after it locates the user. 

    Update geolocation tests to adapt to changes.
    @prushforth
    prushforth committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    a55c9e9 View commit details
    Browse the repository at this point in the history

  4. Add feature index tests for after reload, fullscreen, history nav, 

    geolocation activation,
    @prushforth
    prushforth committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    3368adb View commit details
    Browse the repository at this point in the history

  5. Add test feature index presence post-geolocation activation, 

    deactivation, and link following actions
    @prushforth
    prushforth committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    176cc37 View commit details
    Browse the repository at this point in the history

  6. Formatting by prettier

    @prushforth
    prushforth committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ba49116 View commit details
    Browse the repository at this point in the history

  7. Split up slow test

    @prushforth
    prushforth committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    183a6ee View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. Make feature index overlay responsive to map width

    @prushforth
    prushforth committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    f9b1f72 View commit details
    Browse the repository at this point in the history