Add a default projection (OSMTILE) for the map #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
prushforth
force-pushed
the
default-map-projection
branch
from
61a78cc
to
d2b6e72
Compare
This was referenced Sep 5, 2023
|
ToDo -
current known issues on experiments (need to re-verify after latest commits) -
Other issues/problems found that exist on main also -
Things to do after this PR is pushed -
|
prushforth
force-pushed
the
default-map-projection
branch
from
3f56b0c
to
d31fcf0
Compare
This was
linked to
issues
Sep 22, 2023
Get rid of
createmap event, replace with default projection + changeprojection event + handlers
#864
Closed
|
Tests pass on windows, fail on linux (wsl2) locally, same error messages as on CI, so need to figure that out. |
|
The QueryHandler is querying the layer control for the order of map-extent elements, but it should be querying the DOM and / or ShadowDOM for that order, since the layer control may not be in use,only the content of the layer- either in light or shadow root |
Add default projection (OSMTILE) + remove use of 'createmap' events
function declarations to encapsulate and make the whole process a bit understandable. Not finished yet, but it builds. Fix spooky errors due to closure and other unknowns TBD Tune to closure scopes, add comment, rename attachToLayer to copyRemoteContentToShadowRoot Add temporarily named function for dealing with projection matching Tests not working, some problems with custom projections.
initial extent era.
WIP on tests, label, timing More WIP
…e method WIP on thinkOfAGoodName
Change signature of createLayerControlExtentHTML
Fix broken test mismatchedLayerWithMap test by running _validateDisabled on extentload.
functions for use in / by _initialize / _processContent
happen during initialization.
…n test Essentially what we did before lunch / late Wednesday
…MLLayer per below Refactor MapMLLayer and layer.js so that fetching is done by layer.js Temporarily rename MapMLLayer 'extentload' event to 'foo', so as to avoid collision with 'extentload' event
…er connectedcallback Comment out testing for now, while things are crazy Change 'extentload' to 'foo' in map-feature temporarily Fix mapml-viewer.whenProjectionDefined to remove setTimeout function that defines failure in case of success. Add whenProjectionDefined test to setter for projection
created during _initialize, as the content is available via parameter
…ents to depend on for initialization of parent / required dependencies.
FeatureLayer.js - move code from initialization to onAdd so map available map-features.js - wait until _layer is ready to initialize - TODO wait until map-extent is ready feature.js - temporarily removed creation of an event handler during link creation because it was accessing the _layer which didn't exist TOOD - revisit, figure out how to create event handler without _layer access MapMLLayer.js - adapt changeStyle event handler to stop propagation of event when selecting different style from option, because it was accessing the _layer (this is a bug fix for main, too). web-map.js - copy equivalent changes from mapml-viewer.js
…t been determined
…uld be rendered on map or not for features' first time rendering
gets updated by layer control slider and layer- setter.
not set (setter not run), should return the attribute value if _opacity is nullish.
not set (setter not run), should return the attribute value if _opacity is nullish. Update to do list Work in progress - BNG and Feature Links (BC link) seem to have mutually exclusive solutions - zoomTo after changing projection on map is necessary to inform Leaflet of the changed CRS (scale difference) but the history gets messed up and the BC link doesn't quite render (you have to generate a moveend on the map, then it'll draw). Removed a section of code from _handleLink that sets the map viewer projection when there is a single map layer and it has a different projection from that of the map BECAUSE this is handled by the MapMLLayer in selectAlternateProjection and we don't want to trigger the promise involved in disconnecting / reconnecting all map layers (happens when mapml-viewer projection attribute changed callback happens).
…gedCallback is triggered, avoiding the wrong map lat,lng and zoom information read in attributeChangedCallback closure
post-projection change sequence so that history is correctly initialized, hopefully. Update to do list
Enable playwright tests, disable jest tests, possibly forever. Skip featureIndexOverlay tests for now Do 'npx playwright install' after 'npm install' per playwright error message.
directly at the command prompt, hopefully. Delete to do list, tracked on PR notes WIP on getting featureIndexOverlay to behave Add localized message to feature index output for 'No features found' Remove commented code Remove unused / uncovered code, add comments. Update _handleLink to focus map when finished handling, so that the feature index shows up again (if enabled). Ensure feature index and reticle displayed after reload Ensure feature index and reticle displayed before and after fullscreen Upgrade playwright Add tests for feature index and reticle display after fullscreen, history navigation, link activation. De-flake a test that got really bad post-upgrade of playwright Remove layerchange layeradd layerremove overlayremove events from feature index handlers; the index and reticle display on map focus, disappear when focus moves off map. This seems a bit odd when adding or removing layers, but it is simple, and reticle returns with focus. Update GeolocationButton to focus the map after it locates the user. Update geolocation tests to adapt to changes. Add feature index tests for after reload, fullscreen, history nav, geolocation activation, Add test feature index presence post-geolocation activation, deactivation, and link following actions Formatting by prettier Split up slow test Make feature index overlay responsive to map width Change x client from npx to npm for ci testing
wait until all results are in before merging into popup interface. Extend waiting period to 1s when re-ordering extents via layer control, so that browser processing can finish.
Remove timeout from multipleHeterogeneousQueryExtents test Remove windows/linux system dependency from test Fix system dependency for copy-pasting text in test
prushforth
force-pushed
the
default-map-projection
branch
2 times, most recently
from
3697c30
to
f8f9109
Compare
…nder to add events in map-feature.js Intentionally set focus on map viewer at test begin Attempt to remove system dependencies in tests Prettier format Change tests to use https when accessing WMS services Revert timeout for playwright to 30s
prushforth
force-pushed
the
default-map-projection
branch
from
7394346
to
6ff586f
Compare
and the zoom of the map.
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
ToDo -
[ ] move createAndAddTemplatedLayers from on add in mapmlLayer to process content similar to how we handler other layer typesShould be done as part of map-extent custom element development.current known issues on experiments (need to re-verify after latest commits) -
Other issues/problems found that exist on main also -
Things to do after this PR is pushed -