Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ramp): upgrade ramp-sdk to @2.0.4 #13318

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

georgeweiler
Copy link
Contributor

Description

This upgrades @consensys/on-ramp-sdk to 2.0.3, which is a major version change that updates the getQuotes and getSellQuotes interfaces.

Related issues

Fixes:

Manual testing steps

  1. Go to ramp experience and confirm that quotes and sell quotes are loaded.

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgeweiler georgeweiler added team-ramp issues related to Ramp features needs-ramp-qa Tickets that need feature QA on the ramps flows labels Feb 3, 2025
@georgeweiler georgeweiler requested review from a team as code owners February 3, 2025 17:17
Copy link
Contributor

github-actions bot commented Feb 3, 2025

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgeweiler georgeweiler changed the title Feat/ramp sdk @2.0.3 chore(ramp): upgrade ramp-sdk to @2.0.3 Feb 3, 2025
@georgeweiler georgeweiler added the Run Smoke E2E Triggers smoke e2e on Bitrise label Feb 3, 2025
Copy link

socket-security bot commented Feb 3, 2025

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@consensys/[email protected] 🔁 npm/@consensys/[email protected] None 0 418 kB consensys-npm

View full report↗︎

Copy link
Contributor

github-actions bot commented Feb 3, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9f9ede1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/47a9431e-ba13-4869-8bc5-93739718ca91

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wachunei wachunei removed the needs-ramp-qa Tickets that need feature QA on the ramps flows label Feb 3, 2025
NicolasMassart
NicolasMassart previously approved these changes Feb 4, 2025
Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would love a unit test here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: could you take this opportunity to add a unit test for the hook?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it coming in a next PR, the hook will change a little bit so it is not worth it now, here it is: https://github.com/MetaMask/metamask-mobile/pull/13257/files#diff-66e86df8336a31e6a8432fb36644448548574f07052e57c265b4011145d0a423

@wachunei wachunei mentioned this pull request Feb 4, 2025
7 tasks
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickly after adoption of v2.0.3 it was deprecated, this must be updated to v2.0.4

@georgeweiler georgeweiler changed the title chore(ramp): upgrade ramp-sdk to @2.0.3 chore(ramp): upgrade ramp-sdk to @2.0.4 Feb 4, 2025
@georgeweiler georgeweiler added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e22098f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d2e53cbc-c273-4aa9-abc6-7f54406cc70e

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@georgeweiler georgeweiler added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a1b66c5
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/15b4dd31-6182-4f35-a139-b1dc4cd8a300

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@georgeweiler georgeweiler added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 79f4b5d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d00569dc-17c9-451c-9166-b0338f15e536

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Copy link

sonarqubecloud bot commented Feb 4, 2025

Copy link
Contributor

@NicolasMassart NicolasMassart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Thanks for the effort you made to provide the followup test PR! Very appreciated!

@georgeweiler georgeweiler added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Smoke E2E Triggers smoke e2e on Bitrise team-ramp issues related to Ramp features
Projects
Status: Review finalised - Ready to be merged
Development

Successfully merging this pull request may close these issues.

3 participants