-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ramp): upgrade ramp-sdk to @2.0.4 #13318
base: main
Are you sure you want to change the base?
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Bitrise❌❌❌ Commit hash: 9f9ede1 Note
Tip
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I would love a unit test here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: could you take this opportunity to add a unit test for the hook?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have it coming in a next PR, the hook will change a little bit so it is not worth it now, here it is: https://github.com/MetaMask/metamask-mobile/pull/13257/files#diff-66e86df8336a31e6a8432fb36644448548574f07052e57c265b4011145d0a423
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quickly after adoption of v2.0.3 it was deprecated, this must be updated to v2.0.4
Bitrise❌❌❌ Commit hash: e22098f Note
Tip
|
Bitrise❌❌❌ Commit hash: a1b66c5 Note
Tip
|
Bitrise❌❌❌ Commit hash: 79f4b5d Note
Tip
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Thanks for the effort you made to provide the followup test PR! Very appreciated!
Description
This upgrades @consensys/on-ramp-sdk to 2.0.3, which is a major version change that updates the getQuotes and getSellQuotes interfaces.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist